Skip to content

Still buffer overflows with rDNS tags #62

@ocococococ

Description

@ocococococ

Using ASAN options, I tried to fix buffer overflows with rDNS tags.

Navigating through the original source code is not easy and even if I did not find where the actual overflow happens, I think the proposed workaround would/could be acceptable.
Adding 4 more bytes than normally necessary when allocating memory storing rDNS name seems to bypass the problem.
So maybe someone would be interested in testing this in another context or even finding a better solution.

Here comes a potential patch to solve the problem.
reverseDNS.patch

image

Here comes a sample .sh script that adds many rDNS tags to a .m4a file converted from a .flac file.
try.sh.zip

image

Here comes the ASAN report without the patch.
asan.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions