Fix test

Since we're mocking the provider no entries are actually being deleted anywhere

Author: rolandgeider

lib/widgets/weight/entries_list.dart

@@ -81,23 +81,24 @@ class WeightEntriesList extends StatelessWidget {
                                     ),
                                   )),
                           PopupMenuItem(
-                              child: Text(AppLocalizations.of(context).delete),
-                              onTap: () async {
-                                // Delete entry from DB
-                                await weightProvider.deleteEntry(currentEntry.id!);
+                            child: Text(AppLocalizations.of(context).delete),
+                            onTap: () async {
+                              // Delete entry from DB
+                              await weightProvider.deleteEntry(currentEntry.id!);
 
-                                // and inform the user
-                                if (context.mounted) {
-                                  ScaffoldMessenger.of(context).showSnackBar(
-                                    SnackBar(
-                                      content: Text(
-                                        AppLocalizations.of(context).successfullyDeleted,
-                                        textAlign: TextAlign.center,
-                                      ),
+                              // and inform the user
+                              if (context.mounted) {
+                                ScaffoldMessenger.of(context).showSnackBar(
+                                  SnackBar(
+                                    content: Text(
+                                      AppLocalizations.of(context).successfullyDeleted,
+                                      textAlign: TextAlign.center,
                                     ),
-                                  );
-                                }
-                              })
+                                  ),
+                                );
+                              }
+                            },
+                          )
                         ];
                       },
                     ),

test/weight/weight_provider_test.dart

@@ -31,7 +31,7 @@ import 'weight_provider_test.mocks.dart';
 
 @GenerateMocks([WgerBaseProvider])
 void main() {
-  var mockBaseProvider = MockWgerBaseProvider();
+  late MockWgerBaseProvider mockBaseProvider;
 
   setUp(() {
     mockBaseProvider = MockWgerBaseProvider();

test/weight/weight_screen_test.dart

@@ -33,12 +33,14 @@ import 'weight_screen_test.mocks.dart';
 
 @GenerateMocks([BodyWeightProvider])
 void main() {
-  var mockWeightProvider = MockBodyWeightProvider();
+  late MockBodyWeightProvider mockWeightProvider;
 
-  Widget createWeightScreen({locale = 'en'}) {
+  setUp(() {
     mockWeightProvider = MockBodyWeightProvider();
     when(mockWeightProvider.items).thenReturn(getWeightEntries());
+  });
 
+  Widget createWeightScreen({locale = 'en'}) {
     return ChangeNotifierProvider<BodyWeightProvider>(
       create: (context) => mockWeightProvider,
       child: MaterialApp(
@@ -63,18 +65,18 @@ void main() {
   });
 
   testWidgets('Test deleting an item using the Delete button', (WidgetTester tester) async {
+    // Arrange
     await tester.pumpWidget(createWeightScreen());
 
+    // Act
     expect(find.byType(ListTile), findsNWidgets(2));
-
     await tester.tap(find.byTooltip('Show menu').first);
     await tester.pumpAndSettle();
 
+    // Assert
     await tester.tap(find.text('Delete'));
     await tester.pumpAndSettle();
-
     verify(mockWeightProvider.deleteEntry(1)).called(1);
-    expect(find.byType(ListTile), findsOneWidget);
   });
 
   testWidgets('Test the form on the body weight screen', (WidgetTester tester) async {
@@ -89,7 +91,6 @@ void main() {
   testWidgets('Tests the localization of dates - EN', (WidgetTester tester) async {
     await tester.pumpWidget(createWeightScreen());
 
-    // One in the entries list, one in the chart
     expect(find.text('1/1/2021'), findsOneWidget);
     expect(find.text('1/10/2021'), findsOneWidget);
   });