Correctly initialize the data in form from existing session

Also, add some simple tests for this

Author: rolandgeider

lib/models/workouts/session.dart

@@ -36,8 +36,8 @@ class WorkoutSession {
   @JsonKey(required: true, toJson: dateToYYYYMMDD)
   late DateTime date;
 
-  @JsonKey(required: true, fromJson: stringToNum, toJson: numToString)
-  late num impression;
+  @JsonKey(required: true, fromJson: int.parse, toJson: numToString)
+  late int impression;
 
   @JsonKey(required: false, defaultValue: '')
   late String notes;

lib/models/workouts/session.g.dart

@@ -15,6 +15,7 @@
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
+import 'package:clock/clock.dart';
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart' as provider;
 import 'package:wger/exceptions/http_exception.dart';
@@ -33,23 +34,22 @@ class SessionPage extends StatefulWidget {
   final Routine _routine;
   late WorkoutSession _session;
   final PageController _controller;
-  final TimeOfDay _start;
   final Map<Exercise, int> _exercisePages;
 
   SessionPage(
     this._routine,
     this._controller,
-    this._start,
+    start,
     this._exercisePages,
   ) {
     _session = _routine.sessions.map((sessionApi) => sessionApi.session).firstWhere(
-          (session) => session.date.isSameDayAs(DateTime.now()),
+          (session) => session.date.isSameDayAs(clock.now()),
           orElse: () => WorkoutSession(
             routineId: _routine.id!,
             impression: DEFAULT_IMPRESSION,
-            date: DateTime.now(),
+            date: clock.now(),
             timeEnd: TimeOfDay.now(),
-            timeStart: _start,
+            timeStart: start,
           ),
         );
   }
@@ -65,17 +65,18 @@ class _SessionPageState extends State<SessionPage> {
   final timeStartController = TextEditingController();
   final timeEndController = TextEditingController();
 
-  // final _session = WorkoutSession.now();
-
   /// Selected impression: bad, neutral, good
-  var selectedImpression = [false, true, false];
+  var selectedImpression = [false, false, false];
 
   @override
   void initState() {
     super.initState();
 
     timeStartController.text = timeToString(widget._session.timeStart)!;
     timeEndController.text = timeToString(widget._session.timeEnd)!;
+    notesController.text = widget._session.notes;
+
+    selectedImpression[widget._session.impression - 1] = true;
   }
 
   @override
@@ -212,6 +213,7 @@ class _SessionPageState extends State<SessionPage> {
                   ],
                 ),
                 ElevatedButton(
+                  key: const ValueKey('save-button'),
                   child: Text(AppLocalizations.of(context).save),
                   onPressed: () async {
                     // Validate and save the current values to the weightEntry

lib/widgets/routines/gym_mode/session_page.dart

@@ -269,6 +269,8 @@ void main() {
       findsNWidgets(2),
       reason: 'start and end time are the same',
     );
+    final toggleButtons = tester.widget<ToggleButtons>(find.byType(ToggleButtons));
+    expect(toggleButtons.isSelected[1], isTrue);
     expect(find.byIcon(Icons.chevron_left), findsOneWidget);
     expect(find.byIcon(Icons.close), findsOneWidget);
     expect(find.byIcon(Icons.chevron_right), findsNothing);

test/workout/gym_mode_screen_test.dart

@@ -0,0 +1,81 @@
+/*
+ * This file is part of wger Workout Manager <https://github.com/wger-project>.
+ * Copyright (C) wger Team
+ *
+ * wger Workout Manager is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * wger Workout Manager is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import 'package:clock/clock.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:mockito/annotations.dart';
+import 'package:mockito/mockito.dart';
+import 'package:provider/provider.dart';
+import 'package:wger/l10n/generated/app_localizations.dart';
+import 'package:wger/providers/routines.dart';
+import 'package:wger/widgets/routines/gym_mode/session_page.dart';
+
+import '../../test_data/routines.dart';
+import 'gym_mode_session_screen_test.mocks.dart';
+
+@GenerateMocks([RoutinesProvider])
+void main() {
+  final mockRoutinesProvider = MockRoutinesProvider();
+
+  final testRoutine = getTestRoutine();
+
+  Widget renderSessionPage({locale = 'en'}) {
+    return ChangeNotifierProvider<RoutinesProvider>(
+      create: (context) => mockRoutinesProvider,
+      child: MaterialApp(
+        locale: Locale(locale),
+        localizationsDelegates: AppLocalizations.localizationsDelegates,
+        supportedLocales: AppLocalizations.supportedLocales,
+        home: Scaffold(
+          body: SessionPage(
+            testRoutine,
+            PageController(),
+            const TimeOfDay(hour: 12, minute: 34),
+            const {},
+          ),
+        ),
+      ),
+    );
+  }
+
+  testWidgets('Test that data from  session is loaded', (WidgetTester tester) async {
+    withClock(Clock.fixed(DateTime(2021, 5, 1)), () async {
+      await tester.pumpWidget(renderSessionPage());
+      expect(find.text('10:00'), findsOneWidget);
+      expect(find.text('12:34'), findsOneWidget);
+      expect(find.text('This is a note'), findsOneWidget);
+      final toggleButtons = tester.widget<ToggleButtons>(find.byType(ToggleButtons));
+      expect(toggleButtons.isSelected[2], isTrue);
+    });
+  });
+
+  testWidgets('Test that correct data is send to server', (WidgetTester tester) async {
+    withClock(Clock.fixed(DateTime(2021, 5, 1)), () async {
+      await tester.pumpWidget(renderSessionPage());
+      await tester.tap(find.byKey(const ValueKey('save-button')));
+      final captured = verify(mockRoutinesProvider.editSession(captureAny)).captured.single;
+
+      expect(captured.id, 1);
+      expect(captured.impression, 3);
+      expect(captured.notes, equals('This is a note'));
+      expect(captured.timeStart, equals(const TimeOfDay(hour: 10, minute: 0)));
+      expect(captured.timeEnd, equals(const TimeOfDay(hour: 12, minute: 34)));
+    });
+  });
+}