Skip to content

Commit 48609e2

Browse files
committed
Update
1 parent 5d84cc7 commit 48609e2

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

bazel/foreign_cc/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ load("@rules_foreign_cc//foreign_cc:configure.bzl", "configure_make")
44

55
licenses(["notice"]) # Apache 2
66

7+
exports_files(["icu_data_filter.json"])
8+
79
envoy_package()
810

911
# autotools packages are unusable on Windows as-is
@@ -143,8 +145,6 @@ configure_make(
143145
cc_library(
144146
name = "unicode_icu",
145147
tags = ["skip_on_windows"],
146-
# Can not be used for the core dataplane due to security concerns
147-
visibility = ["//contrib/language/filters/http/source:__pkg__"],
148148
deps = ["unicode_icu_build"],
149149
)
150150

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"strategy": "additive",
3+
"featureFilters": {
4+
"misc": "include"
5+
}
6+
}
7+

bazel/repository_locations.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -898,6 +898,9 @@ REPOSITORY_LOCATIONS_SPEC = dict(
898898
cpe = "N/A",
899899
#license = "googleurl",
900900
#license_url = "https://quiche.googlesource.com/googleurl/+/{version}/LICENSE",
901+
deps = [
902+
"//bazel/foreign_cc:unicode_icu"
903+
]
901904
),
902905
com_google_cel_cpp = dict(
903906
project_name = "Common Expression Language (CEL) C++ library",

source/common/http/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ envoy_cc_library(
502502
"//source/common/common:logger_lib",
503503
"//source/common/runtime:runtime_features_lib",
504504
"@com_googlesource_googleurl//url",
505-
"//bazel/foreign_cc:unicode_icu_build",
505+
"//bazel/foreign_cc:unicode_icu",
506506
],
507507
)
508508

0 commit comments

Comments
 (0)