Skip to content

Commit 695e858

Browse files
committed
Omit non-threshold metrics in bencher output
1 parent 2c177ec commit 695e858

File tree

4 files changed

+16
-46
lines changed

4 files changed

+16
-46
lines changed

.github/workflows/lustre-metrics-bench.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ jobs:
5959
--err \
6060
--adapter rust_iai_callgrind \
6161
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
62+
--ci-only-thresholds \
6263
"cargo bench --bench lustre_metrics"
6364
6465
- name: Compare Lustre Metrics Benchmarks with main branch
@@ -74,4 +75,5 @@ jobs:
7475
--err \
7576
--adapter rust_iai_callgrind \
7677
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
78+
--ci-only-thresholds \
7779
"cargo bench --bench lustre_metrics"

.github/workflows/quota-parsing.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,16 @@ jobs:
2929
--token '${{ secrets.BENCHER_API_TOKEN }}' \
3030
--branch main \
3131
--testbed ci-runner \
32-
--threshold-measure Latency \
32+
--threshold-measure latency \
3333
--threshold-test t_test \
3434
--threshold-max-sample-size 64 \
3535
--threshold-lower-boundary 0.95 \
3636
--threshold-upper-boundary 0.95 \
3737
--err \
3838
--adapter rust_criterion \
3939
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
40+
--ci-only-thresholds \
41+
--ci-id '${{ github.workflow_ref }}-performance' \
4042
"cargo bench --bench combine_performance"
4143
4244
- name: Compare quota parsing metrics benchmarks with main branch
@@ -52,6 +54,8 @@ jobs:
5254
--err \
5355
--adapter rust_criterion \
5456
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
57+
--ci-only-thresholds \
58+
--ci-id '${{ github.workflow_ref }}-performance' \
5559
"cargo bench --bench combine_performance"
5660
5761
- name: Run quota parsing memory usage benchmark
@@ -67,14 +71,16 @@ jobs:
6771
--token '${{ secrets.BENCHER_API_TOKEN }}' \
6872
--branch main \
6973
--testbed ci-runner \
70-
--threshold-measure peak_rss_mib \
74+
--threshold-measure start_rss_mib \
7175
--threshold-test t_test \
7276
--threshold-max-sample-size 64 \
7377
--threshold-lower-boundary 0.95 \
7478
--threshold-upper-boundary 0.95 \
7579
--err \
7680
--adapter json \
7781
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
82+
--ci-only-thresholds \
83+
--ci-id '${{ github.workflow_ref }}-memory' \
7884
--file lustre-collector/combine_mem_usage.json
7985
8086
- name: Compare quota parsing memory metrics with main branch
@@ -90,4 +96,6 @@ jobs:
9096
--err \
9197
--adapter json \
9298
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
99+
--ci-only-thresholds \
100+
--ci-id '${{ github.workflow_ref }}-memory' \
93101
--file lustre-collector/combine_mem_usage.json

.github/workflows/scrape-memory-metrics-bench.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
--err \
5353
--adapter json \
5454
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
55+
--ci-only-thresholds \
56+
--ci-id '${{ github.workflow_ref }}' \
5557
--file lustrefs-exporter/scrape_allocations_results.json
5658
5759
- name: Compare scrape memory metrics with main branch
@@ -67,4 +69,6 @@ jobs:
6769
--err \
6870
--adapter json \
6971
--github-actions '${{ secrets.GITHUB_TOKEN }}' \
72+
--ci-only-thresholds \
73+
--ci-id '${{ github.workflow_ref }}' \
7074
--file lustrefs-exporter/scrape_allocations_results.json

lustre-collector/combine_mem_usage.json

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)