Skip to content

Commit 7848e6d

Browse files
committed
Rename benchmarks
1 parent 5088f4b commit 7848e6d

File tree

4 files changed

+32
-35
lines changed

4 files changed

+32
-35
lines changed

lustre-collector/benches/combine_memory.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use combine::parser::EasyParser;
22
use lustre_collector::quota::parse as combine_parse;
3-
use memory_benchmarking::{BencherOutput, trace_memory};
4-
use std::time::Duration;
3+
use memory_benchmarking::{MemoryMetrics, trace_memory};
4+
use std::{collections::HashMap, time::Duration};
55

66
pub fn main() {
77
let buffer = std::fs::read_to_string("benches/quotas.yml").expect("Failed to read file");
@@ -24,10 +24,11 @@ pub fn main() {
2424
})
2525
.collect();
2626

27-
let bencher_output: BencherOutput = samples.as_slice().into();
27+
let memory_usage: MemoryMetrics = samples.as_slice().into();
2828

29-
let serialized_metrics = serde_json::to_string_pretty(&bencher_output)
30-
.expect("Failed to serialize benchmark output.");
29+
let serialized_metrics =
30+
serde_json::to_string_pretty(&HashMap::from([("quota_parsing", memory_usage)]))
31+
.expect("Failed to serialize benchmark output.");
3132

3233
println!("{serialized_metrics}");
3334
}

lustrefs-exporter/benches/scrape_memory_metrics.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
mod common;
66

77
use common::load_test_concurrent;
8-
use memory_benchmarking::{BencherOutput, trace_memory_async};
9-
use std::time::Duration;
8+
use memory_benchmarking::{MemoryMetrics, trace_memory_async};
9+
use std::{collections::HashMap, time::Duration};
1010

1111
pub fn main() {
1212
let samples: Vec<_> = (0..10)
@@ -32,8 +32,11 @@ pub fn main() {
3232
})
3333
.collect();
3434

35-
let serialized_metrics = serde_json::to_string_pretty(&BencherOutput::from(samples.as_slice()))
36-
.expect("Failed to serialize benchmark output.");
35+
let serialized_metrics = serde_json::to_string_pretty(&HashMap::from([(
36+
"scrape_memory_usage",
37+
MemoryMetrics::from(samples.as_slice()),
38+
)]))
39+
.expect("Failed to serialize benchmark output.");
3740

3841
println!("{serialized_metrics}");
3942
}

lustrefs-exporter/testcmds/cmds_load_test_concurrent.json

Whitespace-only changes.

memory-benchmarking/src/lib.rs

Lines changed: 19 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,7 @@ use std::time::Duration;
33
use sysinfo::{Pid, ProcessExt, System, SystemExt};
44

55
#[derive(serde::Serialize)]
6-
pub struct BencherOutput {
7-
memory_usage: BencherMetrics,
8-
}
9-
10-
#[derive(serde::Serialize)]
11-
struct BencherMetrics {
6+
pub struct MemoryMetrics {
127
start_rss_mib: MetricEntry,
138
peak_rss_mib: MetricEntry,
149
end_rss_mib: MetricEntry,
@@ -90,27 +85,25 @@ impl GetStatsExt for &[MemoryUsage] {
9085
}
9186
}
9287

93-
impl From<&[MemoryUsage]> for BencherOutput {
88+
impl From<&[MemoryUsage]> for MemoryMetrics {
9489
fn from(samples: &[MemoryUsage]) -> Self {
95-
BencherOutput {
96-
memory_usage: BencherMetrics {
97-
start_rss_mib: samples.get_stats(|x| x.start_rss).bytes_as_mib(),
98-
peak_rss_mib: samples.get_stats(|x| x.max_rss).bytes_as_mib(),
99-
end_rss_mib: samples.get_stats(|x| x.end_rss).bytes_as_mib(),
100-
memory_growth_mib: samples.get_stats(|x| x.memory_growth()).bytes_as_mib(),
101-
peak_over_start_rss_ratio: samples
102-
.get_stats(|x| x.peak_over_start_rss())
103-
.bytes_as_mib(),
104-
avg_runtime_rss_mib: samples.get_stats(|x| x.avg_rss).bytes_as_mib(),
105-
start_virtual_mib: samples.get_stats(|x| x.start_virtual).bytes_as_mib(),
106-
peak_virtual_mib: samples.get_stats(|x| x.max_virtual).bytes_as_mib(),
107-
end_virtual_mib: samples.get_stats(|x| x.end_virtual).bytes_as_mib(),
108-
virtual_growth_mib: samples.get_stats(|x| x.virtual_growth()).bytes_as_mib(),
109-
peak_over_start_virtual_ratio: samples
110-
.get_stats(|x| x.peak_over_start_virtual())
111-
.bytes_as_mib(),
112-
avg_runtime_virtual_mib: samples.get_stats(|x| x.avg_virtual).bytes_as_mib(),
113-
},
90+
MemoryMetrics {
91+
start_rss_mib: samples.get_stats(|x| x.start_rss).bytes_as_mib(),
92+
peak_rss_mib: samples.get_stats(|x| x.max_rss).bytes_as_mib(),
93+
end_rss_mib: samples.get_stats(|x| x.end_rss).bytes_as_mib(),
94+
memory_growth_mib: samples.get_stats(|x| x.memory_growth()).bytes_as_mib(),
95+
peak_over_start_rss_ratio: samples
96+
.get_stats(|x| x.peak_over_start_rss())
97+
.bytes_as_mib(),
98+
avg_runtime_rss_mib: samples.get_stats(|x| x.avg_rss).bytes_as_mib(),
99+
start_virtual_mib: samples.get_stats(|x| x.start_virtual).bytes_as_mib(),
100+
peak_virtual_mib: samples.get_stats(|x| x.max_virtual).bytes_as_mib(),
101+
end_virtual_mib: samples.get_stats(|x| x.end_virtual).bytes_as_mib(),
102+
virtual_growth_mib: samples.get_stats(|x| x.virtual_growth()).bytes_as_mib(),
103+
peak_over_start_virtual_ratio: samples
104+
.get_stats(|x| x.peak_over_start_virtual())
105+
.bytes_as_mib(),
106+
avg_runtime_virtual_mib: samples.get_stats(|x| x.avg_virtual).bytes_as_mib(),
114107
}
115108
}
116109
}

0 commit comments

Comments
 (0)