Address review comments from Will

Author: breuhan

lustre-collector/src/fixtures/osd_active.txt

@@ -10,6 +10,14 @@ osd-ldiskfs.MGS.filesfree=130871
 osd-ldiskfs.ai400x2-MDT0000.filesfree=97713887
 osd-ldiskfs.ai400x2-OST0000.filesfree=1073740846
 osd-ldiskfs.ai400x2-OST0001.filesfree=1073740847
+osd-ldiskfs.ai400x2-OST0001.stats=
+snapshot_time             1750226041.107629473 secs.nsecs
+start_time                1750176720.390243856 secs.nsecs
+elapsed_time              49320.717385617 secs.nsecs
+get_page                  375 samples [usecs] 1 23 2956 28656
+cache_access              297 samples [pages] 830 1024 303934
+cache_hit                 123 samples [pages] 0 1024 303934
+cache_miss                297 samples [pages] 830 1024 303934
 osd-ldiskfs.MGS.filestotal=131072
 osd-ldiskfs.ai400x2-MDT0000.filestotal=97714176
 osd-ldiskfs.ai400x2-OST0000.filestotal=1073741824

lustre-collector/src/osd_parser.rs

@@ -64,6 +64,7 @@ enum OsdStat {
     KBytesTotal(u64),
     BrwStats(Vec<BrwStats>),
     QuotaStats(QuotaStatsOsd),
+    /// Generic OSD statistics (performance counters, operation counts)
     Stats(Vec<Stat>),
 }
 

lustre-collector/src/snapshots/lustre_collector__osd_parser__tests__osd_active_stats.snap

@@ -137,6 +137,83 @@ expression: result
                 },
             ),
         ),
+        Target(
+            Stats(
+                TargetStat {
+                    kind: Ost,
+                    param: Param(
+                        "stats",
+                    ),
+                    target: Target(
+                        "ai400x2-OST0001",
+                    ),
+                    value: [
+                        Stat {
+                            name: "get_page",
+                            units: "usecs",
+                            samples: 375,
+                            min: Some(
+                                1,
+                            ),
+                            max: Some(
+                                23,
+                            ),
+                            sum: Some(
+                                2956,
+                            ),
+                            sumsquare: Some(
+                                28656,
+                            ),
+                        },
+                        Stat {
+                            name: "cache_access",
+                            units: "pages",
+                            samples: 297,
+                            min: Some(
+                                830,
+                            ),
+                            max: Some(
+                                1024,
+                            ),
+                            sum: Some(
+                                303934,
+                            ),
+                            sumsquare: None,
+                        },
+                        Stat {
+                            name: "cache_hit",
+                            units: "pages",
+                            samples: 123,
+                            min: Some(
+                                0,
+                            ),
+                            max: Some(
+                                1024,
+                            ),
+                            sum: Some(
+                                303934,
+                            ),
+                            sumsquare: None,
+                        },
+                        Stat {
+                            name: "cache_miss",
+                            units: "pages",
+                            samples: 297,
+                            min: Some(
+                                830,
+                            ),
+                            max: Some(
+                                1024,
+                            ),
+                            sum: Some(
+                                303934,
+                            ),
+                            sumsquare: None,
+                        },
+                    ],
+                },
+            ),
+        ),
         Target(
             FilesTotal(
                 TargetStat {

lustrefs-exporter/fixtures/stats.json

@@ -3024,6 +3024,15 @@
             "sum": 303934,
             "sumsquare": null
           },
+          {
+            "name": "cache_hits",
+            "units": "pages",
+            "samples": 2810,
+            "min": 830,
+            "max": 2956,
+            "sum": 28656,
+            "sumsquare": null
+          },
           {
             "name": "many_credits",
             "units": "reqs",