Rust: Remove unnecessary pattern matching in cleartext logging query sinks (probably inherited from another query or language where it is used).

geoffw0 · geoffw0 · commit 6c024a5f9ebb · 2025-08-04T19:28:40.000+01:00
diff --git a/rust/ql/lib/codeql/rust/security/CleartextLoggingExtensions.qll b/rust/ql/lib/codeql/rust/security/CleartextLoggingExtensions.qll
@@ -40,6 +40,6 @@ module CleartextLogging {
    * A sink for logging from model data.
    */
   private class ModelsAsDataSink extends Sink {
-    ModelsAsDataSink() { exists(string s | sinkNode(this, s) and s.matches("log-injection%")) }
+    ModelsAsDataSink() { sinkNode(this, "log-injection") }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,6 @@ module CleartextLogging {`
`40`	`40`	`* A sink for logging from model data.`
`41`	`41`	`*/`
`42`	`42`	`private class ModelsAsDataSink extends Sink {`
`43`		`- ModelsAsDataSink() { exists(string s \| sinkNode(this, s) and s.matches("log-injection%")) }`
	`43`	`+ ModelsAsDataSink() { sinkNode(this, "log-injection") }`
`44`	`44`	`}`
`45`	`45`	`}`