Skip to content

Commit 944fd2a

Browse files
committed
Rust: Add explicit types in some (not all) of the test cases.
1 parent 62b7d84 commit 944fd2a

File tree

1 file changed

+3
-3
lines changed
  • rust/ql/test/query-tests/security/CWE-089

1 file changed

+3
-3
lines changed

rust/ql/test/query-tests/security/CWE-089/sqlx.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ use sqlx::Executor;
3939

4040
async fn test_sqlx_mysql(url: &str, enable_remote: bool) -> Result<(), sqlx::Error> {
4141
// connect through a MySQL connection pool
42-
let pool = sqlx::mysql::MySqlPool::connect(url).await?;
43-
let mut conn = pool.acquire().await?;
42+
let pool: sqlx::Pool<sqlx::MySql> = sqlx::mysql::MySqlPool::connect(url).await?;
43+
let mut conn: sqlx::pool::PoolConnection<sqlx::MySql> = pool.acquire().await?;
4444

4545
// construct queries (with extra variants)
4646
let const_string = String::from("Alice");
@@ -61,7 +61,7 @@ async fn test_sqlx_mysql(url: &str, enable_remote: bool) -> Result<(), sqlx::Err
6161
let prepared_query_1 = String::from("SELECT * FROM people WHERE firstname=?"); // (prepared arguments are safe)
6262

6363
// direct execution
64-
let _ = conn.execute(safe_query_1.as_str()).await?; // $ MISSING: sql-sink
64+
let _: sqlx::mysql::MySqlQueryResult = conn.execute(safe_query_1.as_str()).await?; // $ MISSING: sql-sink
6565
let _ = conn.execute(safe_query_2.as_str()).await?; // $ MISSING: sql-sink
6666
let _ = conn.execute(safe_query_3.as_str()).await?; // $ MISSING: sql-sink
6767
let _ = conn.execute(unsafe_query_1.as_str()).await?; // $ MISSING: sql-sink Alert[rust/sql-injection]=args1

0 commit comments

Comments
 (0)