Skip to content

Commit 2e8e916

Browse files
noamrdomenic
andauthored
Use "process the next manual redirect" in navigation
This replaces our use "HTTP-redirect fetch", which was pretty broken. Follows whatwg/fetch#1469. Co-authored-by: Domenic Denicola <[email protected]>
1 parent 37748b0 commit 2e8e916

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

source

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2542,7 +2542,6 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
25422542
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#concept-header-extract-mime-type">extract a MIME type</dfn></li>
25432543
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#legacy-extract-an-encoding">legacy extract an encoding</dfn></li>
25442544
<li><dfn data-x="concept-fetch" data-x-href="https://fetch.spec.whatwg.org/#concept-fetch">fetch</dfn></li>
2545-
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#concept-http-redirect-fetch">HTTP-redirect fetch</dfn></li>
25462545
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#ok-status">ok status</dfn></li>
25472546
<li><dfn data-x="navigation-request" data-x-href="https://fetch.spec.whatwg.org/#navigation-request">navigation request</dfn></li>
25482547
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#concept-network-error">network error</dfn></li>
@@ -2555,6 +2554,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
25552554
<li><dfn data-x="concept-header-list-set" data-x-href="https://fetch.spec.whatwg.org/#concept-header-list-set">set</dfn></li>
25562555
<li><dfn data-x="concept-header-list-get-decode-split" data-x-href="https://fetch.spec.whatwg.org/#concept-header-list-get-decode-split">get, decode, and split</dfn></li>
25572556
<li><dfn data-x="concept-fetch-terminate" data-x-href="https://fetch.spec.whatwg.org/#concept-fetch-terminate">terminate</dfn></li>
2557+
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#process-the-next-manual-redirect">process the next manual redirect</dfn></li>
25582558
<li><dfn data-x-href="https://fetch.spec.whatwg.org/#cross-origin-resource-policy-check">cross-origin resource policy check</dfn></li>
25592559
<li>the <dfn data-x-href="https://fetch.spec.whatwg.org/#requestcredentials"><code>RequestCredentials</code></dfn> enumeration</li>
25602560
<li>the <dfn data-x-href="https://fetch.spec.whatwg.org/#requestdestination"><code>RequestDestination</code></dfn> enumeration</li>
@@ -88912,6 +88912,8 @@ interface <dfn interface>Location</dfn> { // but see also <a href="#the-location
8891288912

8891388913
<li><p>Let <var>commitEarlyHints</var> be null.</p></li>
8891488914

88915+
<li><p>Let <var>fetchController</var> be null.</p></li>
88916+
8891588917
<li>
8891688918
<p>While true:</p>
8891788919

@@ -89004,17 +89006,17 @@ interface <dfn interface>Location</dfn> { // but see also <a href="#the-location
8900489006
<p>Otherwise:</p>
8900589007

8900689008
<ol>
89007-
<li><p>If <var>response</var> is null, <!--FETCH--><span
89008-
data-x="concept-fetch">fetch</span> <var>request</var>, with
89009+
<li><p>If <var>fetchController</var> is null, then set <var>fetchController</var> to the
89010+
result of <!--FETCH--><span data-x="concept-fetch">fetching</span> <var>request</var>, with
8900989011
<i data-x="processEarlyHintsResponse">processEarlyHintsResponse</i> set to the following step
8901089012
given a <span data-x="concept-response">response</span> <var>earlyResponse</var>: If
8901189013
<var>commitEarlyHints</var> is null, then set <var>commitEarlyHints</var> to the result
8901289014
of <span data-x="process early hint headers">processing early hint headers</span> given
8901389015
<var>earlyResponse</var> and <var>request</var>'s
8901489016
<span data-x="concept-request-reserved-client">reserved client</span>.</p></li>
8901589017

89016-
<li><p>Otherwise, perform <span>HTTP-redirect fetch</span> using
89017-
<var>request</var> and <var>response</var>.</p></li>
89018+
<li><p>Otherwise, <span>process the next manual redirect</span> given
89019+
<var>fetchController</var>.</p></li>
8901889020

8901989021
<li><p>Wait for the <span data-x="concept-task">task</span> on the <span>networking task
8902089022
source</span> to <span>process response</span> and set <var>response</var> to the

0 commit comments

Comments
 (0)