Skip to content

Commit 6075687

Browse files
committed
Do not establish close watchers in non-fully active documents
Closes #10634. See #10659 for a better followup.
1 parent 33cf828 commit 6075687

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

source

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61649,8 +61649,9 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
6164961649
to the top layer</span> given <span>this</span>.</p></li>
6165061650

6165161651
<li id="canceling-dialogs">
61652-
<p>Set <span>this</span>'s <span data-x="dialog-close-watcher">close watcher</span> to the
61653-
result of <span data-x="establish a close watcher">establishing a close watcher</span> given
61652+
<p>If <span>this</span>'s <span>node document</span> is <span>fully active</span>, then set
61653+
<span>this</span>'s <span data-x="dialog-close-watcher">close watcher</span> to the result of
61654+
<span data-x="establish a close watcher">establishing a close watcher</span> given
6165461655
<span>this</span>'s <span>relevant global object</span>, with:</p>
6165561656

6165661657
<ul>
@@ -61664,6 +61665,10 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {
6166461665
<li><p><i data-x="create-close-watcher-closeAction">closeAction</i> being to <span>close the
6166561666
dialog</span> given <span>this</span> and null.</p></li>
6166661667
</ul>
61668+
61669+
<p class="XXX">It would be better if this method failed early for the non-<span>fully
61670+
active</span> case. That is being tracked in <a
61671+
href="https://github.com/whatwg/html/issues/10659">issue #10659</a>.</p>
6166761672
</li>
6166861673

6166961674
<li><p>Set <span>this</span>'s <span>previously focused element</span> to the
@@ -85392,9 +85397,10 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8539285397
</li>
8539385398

8539485399
<li id="canceling-popovers">
85395-
<p>Set <var>element</var>'s <span>popover close watcher</span> to the result of <span
85396-
data-x="establish a close watcher">establishing a close watcher</span> given
85397-
<var>element</var>'s <span>relevant global object</span>, with:</p>
85400+
<p>If <var>document</var> is <span>fully active</span>, then set <var>element</var>'s
85401+
<span>popover close watcher</span> to the result of <span data-x="establish a close
85402+
watcher">establishing a close watcher</span> given <var>element</var>'s <span>relevant global
85403+
object</span>, with:</p>
8539885404

8539985405
<ul>
8540085406
<li><p><i data-x="create-close-watcher-cancelAction">cancelAction</i> being to return
@@ -85404,6 +85410,10 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8540485410
data-x="hide popover algorithm">hide a popover</span> given <var>element</var>, true, true,
8540585411
and false.</p></li>
8540685412
</ul>
85413+
85414+
<p class="XXX">It would be better if this algorithm failed early for the non-<span>fully
85415+
active</span> case. That is being tracked in <a
85416+
href="https://github.com/whatwg/html/issues/10659">issue #10659</a>.</p>
8540785417
</li>
8540885418
</ol>
8540985419
</li>

0 commit comments

Comments
 (0)