Skip to content

Commit 847a959

Browse files
authored
Ensure modal dialogs can nest inside of hint popovers
Allow dialogs that are nested inside of a hint popover to be shown as modal. The previous text meant that dialogs may close their parent hint popover causing issues similar to #9998. Make it such that a dialog (or fullscreen element) is a viable candidate to nest inside of a hint popover. Closes #11008, by making the modifications suggested in that issue.
1 parent 41a3b79 commit 847a959

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

source

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -87464,11 +87464,11 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8746487464
data-x="attr-popover-manual-state">Manual</span> or <span
8746587465
data-x="attr-popover-none-state">None</span> state.</p></li>
8746687466

87467-
<li><p>Set <var>okNesting</var> to true if <var>newPopoverOrTopLayerElement</var>'s <code
87468-
data-x="attr-popover">popover</code> attribute is in the <span
87469-
data-x="attr-popover-hint-state">Hint</span> state or <var>candidateAncestor</var>'s <code
87470-
data-x="attr-popover">popover</code> attribute is in the <span
87471-
data-x="attr-popover-auto-state">Auto</span> state.</p></li>
87467+
<li><p>Set <var>okNesting</var> to true if <var>isPopover</var> is false,
87468+
<var>newPopoverOrTopLayerElement</var>'s <code data-x="attr-popover">popover</code> attribute
87469+
is in the <span data-x="attr-popover-hint-state">Hint</span> state, or
87470+
<var>candidateAncestor</var>'s <code data-x="attr-popover">popover</code> attribute is in the
87471+
<span data-x="attr-popover-auto-state">Auto</span> state.</p></li>
8747287472

8747387473
<li><p>If <var>okNesting</var> is false, then set <var>candidate</var> to
8747487474
<var>candidateAncestor</var>'s parent in the <span>flat tree</span>.</p></li>
@@ -87505,7 +87505,8 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8750587505

8750687506
<ol>
8750787507
<li><p>If <var>currentNode</var>'s <code data-x="attr-popover">popover</code> attribute is in
87508-
the <span data-x="attr-popover-auto-state">Auto</span> state and <var>currentNode</var>'s
87508+
the <span data-x="attr-popover-auto-state">Auto</span> state or the <span
87509+
data-x="attr-popover-hint-state">Hint</span> state, and <var>currentNode</var>'s
8750987510
<span>popover visibility state</span> is <span data-x="popover-showing-state">showing</span>,
8751087511
then return <var>currentNode</var>.</p></li>
8751187512

@@ -87965,9 +87966,10 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
8796587966

8796687967
<li><p>If <var>targetPopover</var> is not null and <var>targetPopover</var>'s <code
8796787968
data-x="attr-popover">popover</code> attribute is in the <span
87968-
data-x="attr-popover-auto-state">Auto</span> state and <var>targetPopover</var>'s <span>popover
87969-
visibility state</span> is <span data-x="popover-showing-state">showing</span>, then return
87970-
<var>targetPopover</var>.</p></li>
87969+
data-x="attr-popover-auto-state">Auto</span> state or the <span
87970+
data-x="attr-popover-hint-state">Hint</span> state, and <var>targetPopover</var>'s
87971+
<span>popover visibility state</span> is <span data-x="popover-showing-state">showing</span>,
87972+
then return <var>targetPopover</var>.</p></li>
8797187973

8797287974
<li><p>Set <var>currentNode</var> to <var>currentNode</var>'s ancestor in the <span>flat
8797387975
tree</span>.</p></li>

0 commit comments

Comments
 (0)