Skip to content

Commit b0fdce5

Browse files
committed
fixup @annevk's feedback
1 parent 9d56f34 commit b0fdce5

File tree

1 file changed

+28
-26
lines changed

1 file changed

+28
-26
lines changed

source

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -26067,8 +26067,9 @@ document.body.appendChild(wbr);</code></pre>
2606726067
<span>extract an origin</span> steps:</p>
2606826068

2606926069
<ol>
26070-
<li><p>If <span>this</span>'s <span data-x="concept-hyperlink-url">url</span> is null, return
26071-
null.</p></li>
26070+
<li><p>If <span>this</span>'s <span data-x="concept-hyperlink-url">url</span> is null, then
26071+
return null.</p></li>
26072+
2607226073
<li><p>Return <span>this</span>'s <span data-x="concept-hyperlink-url">url</span>'s
2607326074
<span data-x="concept-url-origin">origin</span>.</p></li>
2607426075
</ol>
@@ -92445,8 +92446,8 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9244592446
boolean <span data-x="dom-Origin-isSameSite">isSameSite</span>(Origin other);
9244692447
};</code></pre>
9244792448

92448-
<p><code data-x="dom-Origin-interface">Origin</code> objects have an
92449-
<dfn for="Origin" attribute>[[origin]]</dfn> internal slot, which holds an
92449+
<p><code data-x="dom-Origin-interface">Origin</code> objects have an associated
92450+
<dfn for="Origin" attribute data-x="dom-Origin-origin">origin</dfn>, which holds an
9245092451
<span>origin</span>.</p>
9245192452

9245292453
<p><span data-x="platform object">Platform objects</span> have an
@@ -92456,15 +92457,15 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9245692457
<div algorithm>
9245792458
<p>Objects implementing the <code data-x="dom-Origin-interface">Origin</code> interface's
9245892459
<span>extract an origin</span> steps are to return <span>this</span>'s
92459-
<span>[[origin]]</span>.</p>
92460+
<span data-x="dom-Origin-origin">origin</span>.</p>
9246092461
</div>
9246192462

9246292463
<div algorithm>
9246392464
<p>The <dfn constructor for="Origin"><code
9246492465
data-x="dom-Origin-constructor">new Origin()</code></dfn> constructor steps are:</p>
9246592466

9246692467
<ol>
92467-
<li><p>Set <span>this</span>'s <span>[[origin]]</span> internal slot to a unique
92468+
<li><p>Set <span>this</span>'s <span data-x="dom-Origin-origin">origin</span> to a unique
9246892469
<span data-x="concept-origin-opaque">opaque origin</span>.</p></li>
9246992470
</ol>
9247092471
</div>
@@ -92481,48 +92482,49 @@ interface <dfn interface data-x="dom-Origin-interface">Origin</dfn> {
9248192482
<ol>
9248292483
<li><p>Let <var>origin</var> be the result of executing <var>value</var>'s <span>extract an
9248392484
origin</span> operation.</p></li>
92484-
<li><p>If <var>origin</var> is not null, return a new
92485-
<code data-x="dom-Origin-interface">Origin</code> object whose <span>[[origin]]</span> is set
92486-
to <var>origin</var>.</p></li>
92485+
92486+
<li><p>If <var>origin</var> is not null, then return a new
92487+
<code data-x="dom-Origin-interface">Origin</code> object whose
92488+
<span data-x="dom-Origin-origin">origin</span> is set to <var>origin</var>.</p></li>
9248792489
</ol>
9248892490
</li>
92491+
9248992492
<li>
9249092493
<p>If <var>value</var> is a <span>string</span>:</p>
9249192494
<ol>
9249292495
<li><p>Let <var>parsed url</var> be the result of <span data-x="basic url parser">basic URL
9249392496
parsing</span> <var>value</var>.</p></li>
92494-
<li><p>If <var>parsed url</var> is not failure, return a new
92495-
<code data-x="dom-Origin-interface">Origin</code> object whose <span>[[origin]]</span> is set
92496-
to <var>parsed url</var>'s <span data-x="concept-url-origin">origin</span>.</p></li>
92497+
92498+
<li><p>If <var>parsed url</var> is not failure, then return a new
92499+
<code data-x="dom-Origin-interface">Origin</code> object whose
92500+
<span data-x="dom-Origin-origin">origin</span> is set to <var>parsed url</var>'s
92501+
<span data-x="concept-url-origin">origin</span>.</p></li>
9249792502
</ol>
92498-
</li>
92503+
</li>
92504+
9249992505
<li><p>Throw a <code>TypeError</code>.</p></li>
9250092506
</ol>
9250192507
</div>
9250292508

9250392509
<div algorithm>
9250492510
<p>The <dfn attribute for="Origin"><code data-x="dom-Origin-opaque">opaque</code></dfn> attribute
92505-
getter steps are to return true if <span>this</span>'s <span>[[origin]]</span> is an <span
92506-
data-x="concept-origin-opaque">opaque origin</span>, and false otherwise.</p>
92511+
getter steps are to return true if <span>this</span>'s
92512+
<span data-x="dom-Origin-origin">origin</span> is an <span data-x="concept-origin-opaque">opaque
92513+
origin</span>, and false otherwise.</p>
9250792514
</div>
9250892515

9250992516
<div algorithm>
9251092517
<p>The <dfn method for="Origin"><code
9251192518
data-x="dom-Origin-isSameOrigin">isSameOrigin(other)</code></dfn> method returns true if
92512-
<span>this</span>'s <span>[[origin]]</span> is <span>same origin</span> with <var>other</var>'s
92513-
<span>[[origin]]</span>, and false otherwise.</p>
92519+
<span>this</span>'s <span data-x="dom-Origin-origin">origin</span> is <span>same origin</span>
92520+
with <var>other</var>'s <span data-x="dom-Origin-origin">origin</span>, and false otherwise.</p>
9251492521
</div>
9251592522

9251692523
<div algorithm>
9251792524
<p>The <dfn method for="Origin"><code
9251892525
data-x="dom-Origin-isSameSite">isSameSite(other)</code></dfn> method returns true if
92519-
<span>this</span>'s <span>[[origin]]</span> is <span>same site</span> with <var>other</var>'s
92520-
<span>[[origin]]</span>, and false otherwise.</p>
92521-
92522-
<p class="note">This is a <span>same site</span>, <em>not</em> <span>schemelessly same
92523-
site</span>, comparison. For the reasons <a
92524-
href="https://url.spec.whatwg.org/#warning-avoid-psl">explained in <cite>URL</cite></a> The
92525-
<code data-x="dom-Origin-interface">Origin</code> origin does not offer schemeless comparison.</p>
92526+
<span>this</span>'s <span data-x="dom-Origin-origin">origin</span> is <span>same site</span> with
92527+
<var>other</var>'s <span data-x="dom-Origin-origin">origin</span>, and false otherwise.</p>
9252692528
</div>
9252792529

9252892530

@@ -123162,13 +123164,13 @@ document.body.appendChild(frame)</code></pre>
123162123164
<li><p>If <span>this</span>'s <span>relevant settings object</span>'s <span
123163123165
data-x="concept-settings-object-origin">origin</span> is not <span>same origin-domain</span>
123164123166
with the <span>entry settings object</span>'s <span
123165-
data-x="concept-settings-object-origin">origin</span>, return null.</p></li>
123167+
data-x="concept-settings-object-origin">origin</span>, then return null.</p></li>
123166123168

123167123169
<li><p>Return <span>this</span>'s return <span>this</span>'s <span>relevant settings
123168123170
object</span>'s <span data-x="concept-settings-object-origin">origin</span>.</p></li>
123169123171
</ol>
123170123172

123171-
<p class="note">Since these objects are potentially accessible cross-origin (e.g. through
123173+
<p class="note">Since these objects are potentially accessible cross-origin (e.g., through
123172123174
<code>WindowProxy</code>), we need a security check here before granting access to the origin.</p>
123173123175
</div>
123174123176

0 commit comments

Comments
 (0)