Review by domenic

nicolo-ribaudo · nicolo-ribaudo · commit e03cd6b09dfa · 2022-10-03T19:13:04.000+02:00
diff --git a/source b/source
@@ -2893,7 +2893,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
      <li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-detacharraybuffer">DetachArrayBuffer</dfn> abstract operation</li>
      <li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-enumerableownproperties">EnumerableOwnProperties</dfn> abstract operation</li>
      <li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-finishdynamicimport">FinishDynamicImport</dfn> abstract operation</li>
-     <li>The <dfn data-x-href="https://ci.tc39.es/preview/tc39/ecma262/pull/2905/#sec-FinishLoadImportedModule">FinishLoadImportedModule</dfn> abstract operation</li>
+     <li>The <dfn data-x-href="https://ci.tc39.es/preview/tc39/ecma262/pull/2905/#sec-FinishLoadingImportedModule">FinishLoadingImportedModule</dfn> abstract operation</li>
      <li>The <dfn data-x="js-OrdinaryFunctionCreate" data-x-href="https://tc39.es/ecma262/#sec-ordinaryfunctioncreate">OrdinaryFunctionCreate</dfn> abstract operation</li>
      <li>The <dfn data-x="js-Get" data-x-href="https://tc39.es/ecma262/#sec-get-o-p">Get</dfn> abstract operation</li>
      <li>The <dfn data-x-href="https://tc39.es/ecma262/#sec-getactivescriptormodule">GetActiveScriptOrModule</dfn> abstract operation</li>
@@ -93319,7 +93319,7 @@ document.querySelector("button").addEventListener("click", bound);
   <p>This diagram illustrates how these algorithms relate to the ones above, as well as to each
   other:</p>
 
-  <svg id="module-script-fetching-diagram" viewBox="0 0 1131 256" style="width: 100%;" role="img" aria-label="Fetch an external module script, fetch a modulepreload module script graph, fetch an inline module script graph, and fetch a module worker script graph all call fetch the descendants of and link a module script.">
+  <svg id="module-script-fetching-diagram" viewBox="0 0 941 256" style="width: 80%; max-width: 1024px" role="img" aria-label="Fetch an external module script, fetch a modulepreload module script graph, fetch an inline module script graph, and fetch a module worker script graph all call fetch the descendants of and link a module script.">
    <style>
    #module-script-fetching-diagram rect {
     stroke: black;
@@ -93355,45 +93355,45 @@ document.querySelector("button").addEventListener("click", bound);
    </g>
    <path d="M90.5,50.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
-   <g transform="translate(380.5,0.5)" class="caller">
+   <g transform="translate(190.5,0.5)" class="caller">
     <rect width="180" height="50"/>
     <foreignObject width="180" height="50">
      <span xmlns="http://www.w3.org/1999/xhtml">fetch a modulepreload module script graph</span>
     </foreignObject>
    </g>
-   <path d="M470.5,50.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
+   <path d="M280.5,50.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
-   <g transform="translate(570.5,0.5)" class="caller">
+   <g transform="translate(380.5,0.5)" class="caller">
     <rect width="180" height="50"/>
     <foreignObject width="180" height="50">
      <span xmlns="http://www.w3.org/1999/xhtml">fetch an inline module script graph</span>
     </foreignObject>
    </g>
-   <path d="M660.5,50.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
+   <path d="M470.5,50.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
-   <g transform="translate(760.5,0.5)" class="caller">
+   <g transform="translate(570.5,0.5)" class="caller">
     <rect width="180" height="50"/>
     <foreignObject width="180" height="50">
      <span xmlns="http://www.w3.org/1999/xhtml">fetch a module worker script graph</span>
     </foreignObject>
    </g>
-   <path d="M850.5,50.5 L945.5,70.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
+   <path d="M660.5,50.5 L755.5,70.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
-   <g transform="translate(950.5,0.5)" class="caller">
+   <g transform="translate(760.5,0.5)" class="caller">
     <rect width="180" height="50"/>
     <foreignObject width="180" height="50">
      <span xmlns="http://www.w3.org/1999/xhtml">fetch a worklet script graph</span>
     </foreignObject>
    </g>
-   <path d="M1040.5,50.5 L945.5,70.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
+   <path d="M850.5,50.5 L755.5,70.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
-   <g transform="translate(855.5,70.5)" class="caller">
+   <g transform="translate(665.5,70.5)" class="caller">
     <rect width="180" height="50"/>
     <foreignObject width="180" height="50">
      <span xmlns="http://www.w3.org/1999/xhtml">fetch a worklet/module worker script graph</span>
     </foreignObject>
    </g>
-   <path d="M945.5,120.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
+   <path d="M755.5,120.5 L470.5,140.5" marker-end="url(#module-script-fetching-diagram-arrow)"/>
 
    <g transform="translate(260.5,140.5)" class="subalgorithm">
     <rect width="420" height="25"/>
@@ -93471,21 +93471,6 @@ document.querySelector("button").addEventListener("click", bound);
     <p class="note">This step will recursively load all the module transitive dependencies.</p>
    </li>
 
-   <li>
-    <p><span>Upon rejection</span> of <var>loading promise</var>, run the
-    following steps:</p>
-
-    <ol>
-     <li><p>If <var>state</var>.[[ParseError]] is not null, set <var>module script</var>'s <span
-     data-x="concept-script-error-to-rethrow">error to rethrow</span> to
-     <var>state</var>.[[ParseError]] and run <var>onComplete</var> given <var>module
-     script</var>.</p></li>
-
-     <!-- loading error -->
-     <li><p>Otherwise, run <var>onComplete</var> give null.</p></li>
-    </ol>
-   </li>
-
    <li>
     <p><span>Upon fulfillment</span> of <var>loading promise</var>, run the following steps:</p>
 
@@ -93496,13 +93481,32 @@ document.querySelector("button").addEventListener("click", bound);
       <p class="note">This step will recursively call <span data-x="js-Link">Link</span> on all of
       the module's unlinked dependencies.</p>
 
-      <p>If this throws an exception, set <var>module script</var>'s <span
+      <p>If this throws an exception, catch it, and set <var>module script</var>'s <span
       data-x="concept-script-error-to-rethrow">error to rethrow</span> to that exception.</p>
      </li>
 
      <li><p>Run <var>onComplete</var> given <var>module script</var>.</p></li>
     </ol>
    </li>
+
+   <li>
+    <p><span>Upon rejection</span> of <var>loading promise</var>, run the
+    following steps:</p>
+
+    <ol>
+     <li><p>If <var>state</var>.[[ParseError]] is not null, set <var>module script</var>'s <span
+     data-x="concept-script-error-to-rethrow">error to rethrow</span> to
+     <var>state</var>.[[ParseError]] and run <var>onComplete</var> given <var>module
+     script</var>.</p></li>
+
+     <li>
+      <p>Otherwise, run <var>onComplete</var> given null.</p>
+
+      <p class="note"><var>state</var>.[[ParseError]] is null when <var>loading promise</var> is
+      rejected due to a loading error.</p>
+     </li>
+    </ol>
+   </li>
   </ol>
 
   <p>To <dfn>fetch a single module script</dfn>, given a <var>url</var>, a <var>fetch client
@@ -93842,7 +93846,7 @@ document.querySelector("button").addEventListener("click", bound);
     <p>Run the steps to <span>synchronously replace the rules of a <code>CSSStyleSheet</code></span>
     on <var>sheet</var> given <var>source</var>.</p>
 
-    <p>If this throws an exception, set <var>script</var>'s <span
+    <p>If this throws an exception, catch it, and set <var>script</var>'s <span
     data-x="concept-script-parse-error">parse error</span> to that exception, and return
     <var>script</var>.</p>
 
@@ -93877,7 +93881,7 @@ document.querySelector("button").addEventListener("click", bound);
    <li>
     <p>Let <var>result</var> be <span>ParseJSONModule</span>(<var>source</var>).</p>
 
-    <p>If this throws an exception, set <var>script</var>'s <span
+    <p>If this throws an exception, catch it, and set <var>script</var>'s <span
     data-x="concept-script-parse-error">parse error</span> to that exception, and return
     <var>script</var>.</p>
    </li>
@@ -95013,13 +95017,19 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
    ».</p></li>
   </ol>
 
-  <h6><dfn>HostLoadImportedModule</dfn>(<var>referrer</var>, <var>moduleRequest</var>,
-  <var>loadState</var>, <var>payload</var>)</h6>
+  <h6 id="the-hostloadimportedmodule-implementation"><dfn>HostLoadImportedModule</dfn>(<var>referrer</var>,
+  <var>moduleRequest</var>, <var>loadState</var>, <var>payload</var>)</h6>
 
   <p>JavaScript contains an <span>implementation-defined</span> <span
   data-x="js-HostLoadImportedModule">HostLoadImportedModule</span> abstract operation. User agents
   must use the following implementation: <ref spec=JAVASCRIPT></p>
 
+  <p class="note">This specification expects the second parameter to be a <span>ModuleRequest
+  Record</span>, instead of a string as specified by ECMA-262. This is under the assumption that the
+  <cite>import assertions</cite> proposal, when updated to use <span>HostLoadImportedModule</span>
+  instead of the previous module loading hooks, will update the abstract operation passing a
+  <span>ModuleRequest Record</span>. <ref spec=JSIMPORTASSERTIONS></p>
+
   <ol>
    <li><p>Let <var>settings object</var> be the <span>current settings object</span>.</p></li>
 
@@ -95028,16 +95038,14 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
     object</span> implements <code>WorkletGlobalScope</code> or <code>ServiceWorkerGlobalScope</code>
     and <var>loadState</var> is undefined, then:</p>
 
-    <p class="note">
-     <var>loadState</var> is undefined when the current fetching process has been initiated by a
-     dynamic <code data-x="">import()</code> call.
-    </p>
+    <p class="note"><var>loadState</var> is undefined when the current fetching process has been
+    initiated by a dynamic <code>import()</code> call.</p>
 
     <ol>
-     <li><p>Let <var>completion</var> be Completion { [[Type]]: throw, [[Value]]: a new
+     <li><p>Let <var>completion</var> be the <span>Completion Record</span> { [[Type]]: throw, [[Value]]: a new
      <code>TypeError</code>, [[Target]]: empty }.</p></li>
 
-     <li><p>Perform <span>FinishLoadImportedModule</span>(<var>referrer</var>,
+     <li><p>Perform <span>FinishLoadingImportedModule</span>(<var>referrer</var>,
      <var>moduleRequest</var>, <var>payload</var>, <var>completion</var>).</p></li>
 
      <li><p>Return.</p></li>
@@ -95070,7 +95078,7 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
      <var>referencing script</var>'s <span data-x="concept-script-script-fetch-options">fetch
      options</span>.</p></li>
 
-     <li><p>Assert: Neither <var>base URL</var> nor <var>fetch options</var> is null, as
+     <li><p>Assert: neither <var>base URL</var> nor <var>fetch options</var> is null, as
      <var>referencing script</var> is a <span>classic script</span> or a <span>JavaScript module
      script</span>.</p></li>
 
@@ -95099,49 +95107,49 @@ import "https://example.com/foo/../module2.mjs";</code></pre>
     </div>
    </li>
 
-   <li><p>Let <var>destination</var> be "script".</p></li>
+   <li><p>Let <var>destination</var> be <code data-x="">"script"</code>.</p></li>
 
-   <li><p>If <var>loadState</var> is not undefined, set <var>destination</var> to
+   <li><p>If <var>loadState</var> is not undefined, then set <var>destination</var> to
    <var>loadState</var>.[[Destination]].</p></li>
 
    <li>
     <p><span>Fetch a single imported module script</span> given <var>settings object</var>,
     <var>base URL</var>, <var>destination</var>, <var>fetch options</var>, <var>fetch
-    referrer</var>, <var>moduleRequest</var>, and with the following steps given <var>module
-    script</var>:</p>
+    referrer</var>, <var>moduleRequest</var>, and <var>onSingleFetchComplete</var> as defined below.
+    If <var>loadState</var> is not undefined and <var>loadState</var>.[[PerformTheFetch]] is not
+    null, pass <var>loadState</var>.[[PerformTheFetch]] along as well.</p>
+
+    <p><var>onSingleFetchComplete</var> given <var>moduleScript</var> is the following
+    algorithm:</p>
 
     <ol>
-     <li><p>If <var>module script</var> is null, then let <var>completion</var> be Completion {
-     [[Type]]: throw, [[Value]]: a new <code>TypeError</code>, [[Target]]: empty }.</p></li>
+     <li><p>If <var>moduleScript</var> is null, then let <var>completion</var> be the
+     <span>Completion Record</span> { [[Type]]: throw, [[Value]]: a new <code>TypeError</code>,
+     [[Target]]: empty }.</p></li>
 
      <li>
-      <p>Otherwise, if <var>module script</var>'s <span data-x="concept-script-parse-error">parse
+      <p>Otherwise, if <var>moduleScript</var>'s <span data-x="concept-script-parse-error">parse
       error</span> is not null, then:</p>
 
       <ol>
-       <li><p>Let <var>parse error</var> be <var>module script</var>'s <span
+       <li><p>Let <var>parseError</var> be <var>moduleScript</var>'s <span
        data-x="concept-script-parse-error">parse error</span>.</p></li>
 
-       <li><p>Let <var>completion</var> be Completion { [[Type]]: throw, [[Value]]: <var>parse
-       error</var>, [[Target]]: empty }.</p></li>
+       <li><p>Let <var>completion</var> be the <span>Completion Record</span> { [[Type]]: throw,
+       [[Value]]: <var>parseError</var>, [[Target]]: empty }.</p></li>
 
        <li><p>If <var>loadState</var> is not undefined and <var>loadState</var>.[[ParseError]] is
-       null, set <var>loadState</var>.[[ParseError]] to <var>parse error</var>.</p></li>
+       null, set <var>loadState</var>.[[ParseError]] to <var>parseError</var>.</p></li>
       </ol>
      </li>
 
-     <li><p>Otherwise, let <var>completion</var> be Completion { [[Type]]: normal, [[Value]]:
-     <var>result</var>'s <span data-x="concept-script-record">record</span>, [[Target]]: empty
-     }.</p></li>
+     <li><p>Otherwise, let <var>completion</var> be the <span>Completion Record</span> { [[Type]]:
+     normal, [[Value]]: <var>result</var>'s <span data-x="concept-script-record">record</span>,
+     [[Target]]: empty }.</p></li>
 
-     <li><p>Perform <span>FinishLoadImportedModule</span>(<var>referrer</var>,
+     <li><p>Perform <span>FinishLoadingImportedModule</span>(<var>referrer</var>,
      <var>moduleRequest</var>, <var>payload</var>, <var>completion</var>).</p></li>
     </ol>
-
-    <p>If <var>loadState</var> is not undefined and <var>loadState</var>.[[PerformTheFetch]] is not
-    null, pass <var>loadState</var>.[[PerformTheFetch]] as <span>fetch a single imported module
-    script</span>'s custom <span data-x="fetching-scripts-perform-fetch">perform the fetch</span>
-    steps.</p>
    </li>
   </ol>
 
