Skip to content

Navigation API: retain upcoming method tracker as temporary variable #11762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Navigation API: retain upcoming method tracker as temporary variable #11762

wants to merge 2 commits into from
+56 −70

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Oct 7, 2025 •
edited by pr-preview bot
Loading

This protects the navigation API's internal state from fudging when navigate() is called from within a navigateerror handler.

Also inline "promote an upcoming API method tracker".

Closes #11735

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )
/nav-history-apis.html ( diff )

@noamr noamr mentioned this pull request Oct 7, 2025
Open
jnjaeschke
jnjaeschke reviewed Oct 8, 2025
View reviewed changes
Copy link

@jnjaeschke jnjaeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this solves the issue. We need to retain the navigation's upcoming non-traverse API method tracker before firing the navigate error event, because that can run script, and re-apply it afterwards.

(sorry, I don't have permission to request changes)

source Outdated

<li><p><span>Promote an upcoming API method tracker to ongoing</span> given
<var>navigation</var> and <var>destinationKey</var>.</p></li>
<li><p>Let <var>upcomingMethodTracker</var> be <var>navigation</var>'s <span>upcoming
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think we need this here. It should be fine the way it was in the old version (directly move the upcoming non-traverse API method tracker into the ongoing API method tracker slot).

@noamr
Copy link
Collaborator Author

noamr commented Oct 8, 2025

I don't think this solves the issue. We need to retain the navigation's upcoming non-traverse API method tracker before firing the navigate error event, because that can run script, and re-apply it afterwards.

(sorry, I don't have permission to request changes)

OK, I want to wait until #11725 is merged (cc @zcorpan) before revising this then.

@zcorpan
Copy link
Member

zcorpan commented Oct 8, 2025

OK, I want to wait until #11725 is merged (cc @zcorpan) before revising this then.

Reviewed and merged now.

@noamr
Copy link
Collaborator Author

noamr commented Oct 13, 2025

How is this @jnjaeschke?
The upcoming tracker is retained before any of the aborts happen, and then passed into the "inner navigate" steps as an argument. I think it matches @natechapin's WIP CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jnjaeschke jnjaeschke jnjaeschke left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Navigation API: upcoming API method tracker is not null if navigate is called from onnavigateerror

3 participants

@noamr @zcorpan @jnjaeschke