Move from CommonJS to standard JS modules

Author: domenic

__tests__/compose-tweet.mjs

@@ -77,7 +77,7 @@ const mockCommits = [
   }
 ];
 
-import composeTweet from "../lib/compose-tweet.js";
+import composeTweet from "../lib/compose-tweet.mjs";
 
 for (const mockCommit of mockCommits) {
   test(mockCommit.name, t => {

__tests__/get-user-status.mjs

@@ -5,8 +5,8 @@ let mockOrgMemberships = new Map(); // GitHub user ID -> array of GitHub orgs
 
 let getUserStatus;
 before(async () => {
-  mock.module("../lib/helpers/json-github-database.js", {
-    defaultExport: {
+  mock.module("../lib/helpers/json-github-database.mjs", {
+    namedExports: {
       get(type) {
         return {
           sha: "doesn't matter",
@@ -16,8 +16,8 @@ before(async () => {
     }
   });
 
-  mock.module("../lib/helpers/github.js", {
-    defaultExport: {
+  mock.module("../lib/helpers/github.mjs", {
+    namedExports: {
       api: {
         orgs: {
           checkPublicMembershipForUser({ org, username }) {
@@ -32,7 +32,7 @@ before(async () => {
     }
   });
 
-  getUserStatus = (await import("../lib/get-user-status.js")).default;
+  getUserStatus = (await import("../lib/get-user-status.mjs")).default;
 });
 
 function individualData(workstreams, verified, { id = "johndoetw" } = {}) {

__tests__/helpers/workstreams.mjs

@@ -30,7 +30,7 @@ before(async () => {
     }
   });
 
-  workstreams = await import("../../lib/helpers/workstreams.js");
+  workstreams = await import("../../lib/helpers/workstreams.mjs");
 });
 
 test("repos", t => {

__tests__/integration.mjs

@@ -8,7 +8,7 @@ before(async () => {
     defaultExport: (await import("../private-config.sample.json", { with: { type: "json" } })).default
   });
 
-  server = (await import("../lib/app.js")).default;
+  server = (await import("../lib/app.mjs")).default;
 });
 
 after(() => {

__tests__/pr-webhook.mjs

@@ -6,7 +6,7 @@ import fromMain from "./__fixtures__/pr-from-main-hook-payload.json" with { type
 
 let mockCreateStatus, mockPRGet, prWebhook;
 before(async () => {
-  mock.module("../lib/get-user-status.js", {
+  mock.module("../lib/get-user-status.mjs", {
     defaultExport: () => {
       return {
         statusField1: "status value 1",
@@ -15,8 +15,8 @@ before(async () => {
     }
   });
 
-  mock.module("../lib/helpers/github.js", {
-    defaultExport: {
+  mock.module("../lib/helpers/github.mjs", {
+    namedExports: {
       api: {
         repos: {
           get createCommitStatus() {
@@ -32,7 +32,7 @@ before(async () => {
     }
   });
 
-  prWebhook = (await import("../lib/pr-webhook.js")).default;
+  prWebhook = (await import("../lib/pr-webhook.mjs")).default;
 });
 
 beforeEach(() => {

__tests__/process-agreement.mjs

@@ -5,18 +5,14 @@ const { BadRequest } = httpErrors;
 let submitAgreement;
 before(async () => {
   // Fake the UUID generator so it is deterministic for snapshot testing.
-  mock.module("crypto", {
-    namedExports: {
-      randomUUID() {
-        return "1d8ab899-4d91-48b8-acfa-bf9cde5ad909";
-      }
-    }
+  mock.method(crypto, "randomUUID", () => {
+    return "1d8ab899-4d91-48b8-acfa-bf9cde5ad909";
   });
 
   // Mock Date.now() to return 0 for deterministic testing
   mock.timers.enable({ apis: ["Date"], now: 0 });
 
-  submitAgreement = (await import("../lib/process-agreement.js")).default;
+  submitAgreement = (await import("../lib/process-agreement.mjs")).default;
 });
 
 // General

__tests__/server-infra/validate-github-webhook.mjs

@@ -6,7 +6,7 @@ before(async () => {
     defaultExport: { webhook: { secret: "hunter2" } }
   });
 
-  validateGitHubWebhook = (await import("../../lib/server-infra/validate-github-webhook.js")).default;
+  validateGitHubWebhook = (await import("../../lib/server-infra/validate-github-webhook.mjs")).default;
 });
 
 [

__tests__/tweet-webhook.mjs

@@ -36,7 +36,7 @@ before(async () => {
     }
   });
 
-  tweetWebhook = (await import("../lib/tweet-webhook.js")).default;
+  tweetWebhook = (await import("../lib/tweet-webhook.mjs")).default;
 });
 
 beforeEach(() => {

__tests__/update-pr.mjs

@@ -8,7 +8,7 @@ import merged from "./__fixtures__/merged-pr.json" with { type: "json" };
 
 let mockCreateStatus, mockGet, updatePR;
 before(async () => {
-  mock.module("../lib/get-user-status.js", {
+  mock.module("../lib/get-user-status.mjs", {
     defaultExport: () => {
       return {
         statusField1: "status value 1",
@@ -17,8 +17,8 @@ before(async () => {
     }
   });
 
-  mock.module("../lib/helpers/github.js", {
-    defaultExport: {
+  mock.module("../lib/helpers/github.mjs", {
+    namedExports: {
       api: {
         pulls: {
           get get() {
@@ -34,7 +34,7 @@ before(async () => {
     }
   });
 
-  updatePR = (await import("../lib/update-pr.js")).default;
+  updatePR = (await import("../lib/update-pr.mjs")).default;
 });
 
 beforeEach(() => {

eslint.config.mjs

@@ -5,13 +5,6 @@ export default [
   {
     ignores: ["coverage/**/*"]
   },
-  {
-    files: ["**/*.js"],
-    languageOptions: {
-      sourceType: "commonjs",
-      globals: globals.node
-    }
-  },
   {
     files: ["**/*.mjs"],
     languageOptions: {