Skip to content

Commit 44190d1

Browse files
authored
Editorial: fix readable/writable file stream examples
* Use `fileHandle.close()` to close a FileHandle * Pass a view to `fileHandle.read()`, since it doesn't accept an ArrayBuffer * Pass `position` to `fileHandle.read()` instead of relying on implicit file positioning
1 parent 5885d94 commit 44190d1

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

index.bs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7302,15 +7302,15 @@ function makeReadableFileStream(filename) {
73027302
},
73037303

73047304
async pull(controller) {
7305-
const buffer = new ArrayBuffer(CHUNK_SIZE);
7305+
const buffer = new Uint8Array(CHUNK_SIZE);
73067306

73077307
const { bytesRead } = await fileHandle.read(buffer, 0, CHUNK_SIZE, position);
73087308
if (bytesRead === 0) {
73097309
await fileHandle.close();
73107310
controller.close();
73117311
} else {
73127312
position += bytesRead;
7313-
controller.enqueue(new Uint8Array(buffer, 0, bytesRead));
7313+
controller.enqueue(buffer.subarray(0, bytesRead));
73147314
}
73157315
},
73167316

@@ -7350,7 +7350,7 @@ function makeReadableByteFileStream(filename) {
73507350
// feature allocates a buffer and passes it to us via byobRequest.
73517351
const v = controller.byobRequest.view;
73527352

7353-
const { bytesRead } = await fileHandle.read(v.buffer, v.byteOffset, v.byteLength);
7353+
const { bytesRead } = await fileHandle.read(v, 0, v.byteLength, position);
73547354
if (bytesRead === 0) {
73557355
await fileHandle.close();
73567356
controller.close();
@@ -7362,7 +7362,7 @@ function makeReadableByteFileStream(filename) {
73627362
},
73637363

73647364
cancel() {
7365-
return fs.close(fd);
7365+
return fileHandle.close();
73667366
},
73677367

73687368
autoAllocateChunkSize: DEFAULT_CHUNK_SIZE
@@ -7470,11 +7470,11 @@ function makeWritableFileStream(filename) {
74707470
},
74717471

74727472
close() {
7473-
return fs.close(fd);
7473+
return fileHandle.close();
74747474
},
74757475

74767476
abort() {
7477-
return fs.close(fd);
7477+
return fileHandle.close();
74787478
}
74797479
});
74807480
}
@@ -7834,6 +7834,7 @@ Isaac Schlueter,
78347834
isonmad,
78357835
Jake Archibald,
78367836
Jake Verbaten,
7837+
James Pryor,
78377838
Janessa Det,
78387839
Jason Orendorff,
78397840
Jeffrey Yasskin,

0 commit comments

Comments
 (0)