Skip to content

Commit d58a68c

Browse files
authored
Meta: upgrade webidl2js dependency in reference implementation
As of version 17, webidl2js now creates iterators, exceptions and promises in the correct realm. This aligns the reference implementation closer to the standard.
1 parent 007d729 commit d58a68c

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

reference-implementation/lib/ReadableStream-impl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports.implementation = class ReadableStreamImpl {
1515
if (underlyingSource === undefined) {
1616
underlyingSource = null;
1717
}
18-
const underlyingSourceDict = UnderlyingSource.convert(underlyingSource);
18+
const underlyingSourceDict = UnderlyingSource.convert(globalObject, underlyingSource);
1919

2020
aos.InitializeReadableStream(this);
2121

reference-implementation/lib/TransformStream-impl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ exports.implementation = class TransformStreamImpl {
1111
if (transformer === undefined) {
1212
transformer = null;
1313
}
14-
const transformerDict = Transformer.convert(transformer);
14+
const transformerDict = Transformer.convert(globalObject, transformer);
1515
if ('readableType' in transformerDict) {
1616
throw new RangeError('Invalid readableType specified');
1717
}

reference-implementation/lib/WritableStream-impl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ exports.implementation = class WritableStreamImpl {
1111
if (underlyingSink === undefined) {
1212
underlyingSink = null;
1313
}
14-
const underlyingSinkDict = UnderlyingSink.convert(underlyingSink);
14+
const underlyingSinkDict = UnderlyingSink.convert(globalObject, underlyingSink);
1515
if ('type' in underlyingSinkDict) {
1616
throw new RangeError('Invalid type is specified');
1717
}

reference-implementation/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"eslint": "^6.8.0",
1919
"minimatch": "^3.0.4",
2020
"opener": "^1.5.1",
21-
"webidl2js": "^16.2.0",
21+
"webidl2js": "^17.1.0",
2222
"wpt-runner": "^5.0.0"
2323
}
2424
}

0 commit comments

Comments
 (0)