Replace lodash.isEqual checks with Object.is

Author: anajavi

packages/react-jsx-highcharts/src/components/BaseChart/BaseChart.js

@@ -1,7 +1,7 @@
 import React, { useState, useEffect, useRef, useLayoutEffect } from 'react';
 import PropTypes from 'prop-types';
 import debounce from '../../utils/debounce-raf';
-import { isEqual, attempt } from 'lodash-es'
+import { attempt } from 'lodash-es'
 import ChartContext from '../ChartContext';
 import { validChartTypes } from '../../utils/propTypeValidators'
 import usePrevious from '../UsePrevious';
@@ -62,7 +62,7 @@ const BaseChart = ({ children = null, callback, className = '', ...restProps}) =
     const { plotOptions } = restProps;
     const myChart = chartRef.current;
     const needsRedraw = providerValueRef.current.needsRedraw;
-    if (isEqual(prevProps.plotOptions, plotOptions) === false && myChart) {
+    if (Object.is(prevProps.plotOptions, plotOptions) === false && myChart) {
       myChart.update({ plotOptions }, false);
       needsRedraw();
     }

packages/react-jsx-highcharts/src/components/Series/Series.js

@@ -1,7 +1,6 @@
 import React, { memo, useRef, useState, useEffect } from 'react';
 import PropTypes from 'prop-types';
 import uuid from 'uuid/v4';
-import { isEqual } from 'lodash-es';
 import { attempt } from 'lodash-es';
 import SeriesContext from '../SeriesContext';
 import { getNonEventHandlerProps, getEventsConfig } from '../../utils/events';
@@ -78,7 +77,7 @@ const Series = memo(({
 
     let doRedraw = false;
     // Using setData is more performant than update
-    if (isEqual(data, prevProps.data) === false) {
+    if (Object.is(data, prevProps.data) === false) {
       series.setData(data, false);
       doRedraw = true;
     }

packages/react-jsx-highcharts/src/utils/getModifiedProps.js

@@ -1,4 +1,3 @@
-import { isEqual } from 'lodash-es';
 import { pickBy } from 'lodash-es';
 
 export default function getModifiedProps (prevProps, currProps, childrenIsText = false) {
@@ -7,10 +6,10 @@ export default function getModifiedProps (prevProps, currProps, childrenIsText =
   const modifiedProps = pickBy(rest, (value, propName) => {
     if (!prevProps) return true;
 
-    return isEqual(value, prevProps[propName]) === false;
+    return Object.is(value, prevProps[propName]) === false;
   });
 
-  if (childrenIsText && (!prevProps || isEqual(prevProps.children, children) === false)) {
+  if (childrenIsText && (!prevProps || Object.is(prevProps.children, children) === false)) {
     modifiedProps.text = children;
   }
 

packages/react-jsx-highcharts/test/components/Series/Series.spec.js

@@ -149,20 +149,36 @@ describe('<Series />', () => {
       expect(testContext.needsRedraw).toHaveBeenCalledTimes(1);
     });
 
-    it('should NOT use the setData method if the data hasn\'t changed', () => {
+    it('should NOT use the setData method if the data reference hasn\'t changed', () => {
+      const data = [1, 2, 3];
       const wrapper = mount(
         <ProvidedSeries
-          id="mySeries" data={[1, 2, 3]} />
+          id="mySeries" data={data} />
       );
-      testContext.seriesStubs.update.mockReset();
+      testContext.seriesStubs.update.mockClear();
       testContext.needsRedraw.mockClear();
-      wrapper.setProps({ data: [1, 2, 3] });
+      testContext.seriesStubs.setData.mockClear();
+      wrapper.setProps({ data });
       expect(testContext.seriesStubs.setData).not.toHaveBeenCalled();
       expect(testContext.seriesStubs.update).not.toHaveBeenCalled();
       expect(testContext.seriesStubs.setVisible).not.toHaveBeenCalled();
       expect(testContext.needsRedraw).not.toHaveBeenCalled();
     });
 
+    it('should use the setData method if the data reference has changed', () => {
+      const wrapper = mount(
+        <ProvidedSeries
+          id="mySeries" data={[1, 2, 3]} />
+      );
+      testContext.seriesStubs.update.mockClear();
+      testContext.needsRedraw.mockClear();
+      wrapper.setProps({ data: [1, 2, 3] });
+      expect(testContext.seriesStubs.setData).toHaveBeenCalled();
+      expect(testContext.seriesStubs.update).not.toHaveBeenCalled();
+      expect(testContext.seriesStubs.setVisible).not.toHaveBeenCalled();
+      expect(testContext.needsRedraw).toHaveBeenCalled();
+    });
+
     it('should use the setVisible method on the correct series when the visibility changes', () => {
       const wrapper = mount(
         <ProvidedSeries