Skip to content

Commit f727018

Browse files
committed
Remove unnecessary eslint-disable react-hooks/exhaustive-deps comments
1 parent 1755a9d commit f727018

File tree

14 files changed

+0
-19
lines changed

14 files changed

+0
-19
lines changed

packages/react-jsx-highcharts/src/components/Annotation/Annotation.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const Annotation = memo((props) => {
2121

2222
const [rendered, setRendered] = useState(false);
2323

24-
// eslint-disable-next-line react-hooks/exhaustive-deps
2524
useEffect(() => {
2625
idRef.current = typeof id === 'function' ? id() : id;
2726
const myId = idRef.current;

packages/react-jsx-highcharts/src/components/Axis/Axis.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const Axis = ({ children = null, dynamicAxis = true, ...restProps }) => {
3030
chart.needsRedraw();
3131
}
3232
}
33-
// eslint-disable-next-line react-hooks/exhaustive-deps
3433
},[]);
3534

3635
const modifiedProps = useModifiedProps(restProps);
@@ -42,7 +41,6 @@ const Axis = ({ children = null, dynamicAxis = true, ...restProps }) => {
4241
axis.update(modifiedProps, false);
4342
chart.needsRedraw();
4443
}
45-
// eslint-disable-next-line react-hooks/exhaustive-deps
4644
});
4745

4846
if (!hasAxis) return null;

packages/react-jsx-highcharts/src/components/Axis/AxisTitle.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const AxisTitle = memo(({ children: text, axisId, ...restProps}) => {
1515
return () => {
1616
if (axis) attempt(updateAxisTitle, { text: null }, axis);
1717
};
18-
// eslint-disable-next-line react-hooks/exhaustive-deps
1918
}, [axis]);
2019

2120
return null;

packages/react-jsx-highcharts/src/components/BarSeries/BarSeries.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ const BarSeries = (props) => {
1212
inverted: true
1313
}
1414
});
15-
// eslint-disable-next-line react-hooks/exhaustive-deps
1615
},[]);
1716

1817
return (

packages/react-jsx-highcharts/src/components/BaseChart/BaseChart.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ const BaseChart = ({ children = null, callback, className = '', ...restProps}) =
4343
providerValueRef.current = providedChart;
4444
if(callback) callback(myChart);
4545
setRendered(true);
46-
// eslint-disable-next-line react-hooks/exhaustive-deps
4746
},[]);
4847

4948
useEffect(() => {

packages/react-jsx-highcharts/src/components/Chart/Chart.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ const Chart = memo(({ type = 'line', ...restProps}) => {
2222
updateChart(restModified, chart, chart.needsRedraw);
2323
}
2424
}
25-
// eslint-disable-next-line react-hooks/exhaustive-deps
2625
});
2726

2827
useEffect(() => {
@@ -34,7 +33,6 @@ const Chart = memo(({ type = 'line', ...restProps}) => {
3433
updateChart(notEventProps, chart);
3534
addEventHandlersManually(Highcharts, chart.object, rest);
3635
mounted.current = true;
37-
// eslint-disable-next-line react-hooks/exhaustive-deps
3836
},[]);
3937

4038
return null;

packages/react-jsx-highcharts/src/components/Debug/Debug.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ const Debug = ({ varName = 'chart' }) => {
1111
// eslint-disable-next-line no-console
1212
console.log(`Chart instance available as global variable as window.${varName}`);
1313
return () => window[varName] = undefined;
14-
// eslint-disable-next-line react-hooks/exhaustive-deps
1514
}, [varName]);
1615

1716
return (

packages/react-jsx-highcharts/src/components/Loading/Loading.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ const Loading = memo(({ children, isLoading = true, ...restProps }) => {
1717
})
1818
useEffect(()=> {
1919
return () => attempt(chart.hideLoading);
20-
// eslint-disable-next-line react-hooks/exhaustive-deps
2120
},[]);
2221

2322
return null;

packages/react-jsx-highcharts/src/components/PlotBandLine/PlotBandLineLabel.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const PlotBandLineLabel = memo(props => {
2020
text: null
2121
});
2222
};
23-
// eslint-disable-next-line react-hooks/exhaustive-deps
2423
}, [plotbandline]);
2524

2625
return null;

packages/react-jsx-highcharts/src/components/PlotBandLine/usePlotBandLineLifecycle.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export default function usePlotBandLine(props, plotType) {
1212
const [plotbandline, setPlotbandline] = useState(null);
1313
const modifiedProps = useModifiedProps(rest);
1414

15-
// eslint-disable-next-line react-hooks/exhaustive-deps
1615
useEffect(() => {
1716
if (!axis) return;
1817
if (modifiedProps !== false && plotbandline) {
@@ -39,7 +38,6 @@ export default function usePlotBandLine(props, plotType) {
3938
return () => {
4039
attempt(axis.removePlotBandOrLine, idRef.current);
4140
};
42-
// eslint-disable-next-line react-hooks/exhaustive-deps
4341
}, [axis]);
4442

4543
return plotbandline;

0 commit comments

Comments
 (0)