Removing evaluate

Removed the use of the evaluate function and instead replaced it with the code that searches for the variables enclosed within ## and then replaces it with the variable's value which it searches from the variables and arguments scopes. If there is no variable between two # then it simply returns a single #

Author: zainforbjs

vendor/wheels/model/validations.cfc

@@ -412,10 +412,31 @@ component {
 		local.rv = arguments.message;
 		// evaluate the error message if it contains pound signs
 		if (Find(Chr(35), local.rv)) {
-			// use a try / catch here since it will fail if a pound sign is used that's not in an expression
-			try {
-				local.rv = Evaluate(De(local.rv));
-			} catch (any e) {
+			// Extract variable names between # symbols
+			local.regex = "(##([^#chr(35)#]*)##|####)";
+			local.matches = REMatchNoCase(local.regex, local.rv);
+			local.matchCount = ArrayLen(local.matches);
+
+			if (local.matchCount) {
+				for (local.i = 1; local.i <= local.matchCount; local.i++) {
+					local.fullMatch = local.matches[local.i]; // The full #variable# match
+
+					// Ensure it contains #
+					if (Find(Chr(35), local.fullMatch)) {
+						local.varName = ReplaceNoCase(local.fullMatch, "#chr(35)#", "", "ALL");
+
+						// If empty ##, replace with a single #
+						if (Len(local.varName) EQ 0) {
+							local.rv = ReplaceNoCase(local.rv, local.fullMatch, Chr(35), "one");
+						} else {
+							// Retrieve variable value from function scope or arguments
+							local.value = StructFind(variables, local.varName, StructFind(arguments, local.varName, local.fullMatch));
+
+							// Replace occurrences of #variable# with the actual value
+							local.rv = ReplaceNoCase(local.rv, local.fullMatch, local.value, "one");
+						}
+					}
+				}
 			}
 		}