Skip to content

Commit 2081fde

Browse files
author
Salma Alam-Naylor
committed
Optimised content for learn
1 parent 45cab69 commit 2081fde

File tree

10 files changed

+65
-34
lines changed

10 files changed

+65
-34
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
// Jest Snapshot v1, https://goo.gl/fbAQLP
2+
3+
exports[`FretonatorComponent should create 1`] = `FretonatorComponentSpec {}`;

apps/fretonator-web/src/app/common/fretonator/fretboard/fretboard.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component, EventEmitter, Input, OnChanges, OnInit, Output } from '@angular/core';
1+
import { Component, EventEmitter, Input, OnChanges, Output } from '@angular/core';
22
import { FretMap, Mode } from '../../../util/types';
33
import { NotePlaybackService } from '../../playback/note-playback.service';
44

apps/fretonator-web/src/app/common/fretonator/fretonator.component.spec.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,8 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
33
import { FretonatorComponent } from './fretonator.component';
44
import { FretonatorModule } from './fretonator.module';
55
import { Component } from '@angular/core';
6-
import { By } from '@angular/platform-browser';
76

87
describe('FretonatorComponent', () => {
9-
10-
const selectors = {
11-
twelveButton: By.css('.fretboard__toggleButton--twelve'),
12-
twentyFourButton: By.css('.fretboard__toggleButton--twentyFour')
13-
};
14-
15-
const classNames = {
16-
toggleFretButtonSelected: 'fretboard__toggleButton--active'
17-
};
18-
198
@Component({
209
selector: 'app-fretonator-spec',
2110
template: `
@@ -54,5 +43,6 @@ describe('FretonatorComponent', () => {
5443

5544
it('should create', () => {
5645
expect(component).toBeTruthy();
46+
expect(component).toMatchSnapshot();
5747
});
5848
});
Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="similarModes" *ngIf="similarModes.length > 0 && !isTheoretical">
22
<h4 class="similarModes__title">Did you know?</h4>
3-
<p class="similarModes__copy">If you know the patterns of {{modeDisplayString}} on the fretboard,
4-
you can transfer those shapes to the modes below.</p>
3+
<p class="similarModes__copy">If you know {{modeDisplayString}} on the fretboard,
4+
you can already play the modes below!</p>
55

66
<div class="chipsContainer">
77
<app-chips>
@@ -13,12 +13,18 @@ <h4 class="similarModes__title">Did you know?</h4>
1313
</app-chips>
1414
</div>
1515

16-
<p class="similarModes__copy">There are only 7 patterns you need to learn. Once you've memorised those patterns,
17-
you can play any of the 7 standard modes <em>(Ionian, Dorian, Phrygian, Lydian, Mixolydian, Aolian, Locrian</em>)
18-
from
19-
any starting note, anywhere on the fretboard.</p>
20-
<p class="similarModes__copy">These patterns always appear in the same order, one after the other.</p>
16+
<p class="similarModes__copy">In order to play and jam in all 7 of the main modes, you <span class="emphasis">only need to learn 7
17+
patterns</span>.
18+
</p>
19+
<p class="similarModes__copy">These patterns always appear in <span class="emphasis">the exact same order</span>
20+
across
21+
the fretboard, regardless of the starting note or mode.</p>
22+
23+
<p class="similarModes__copy">You might have heard this named as the <span
24+
class="emphasis">3 note per string</span> method. Learn more about this and the 7 standard modes of the major scale
25+
in our
26+
learning hub.</p>
2127
<a [routerLink]="['/', 'learn', 'patterns']"
2228
[state]="{scrollToTop: true}"
23-
class="similarModes__cta">Learn more</a>
29+
class="similarModes__cta">Learn about patterns</a>
2430
</div>

apps/fretonator-web/src/app/common/fretonator/similar-modes/similar-modes.component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@
3939
}
4040
}
4141

42+
.emphasis {
43+
font-weight: var(--font-weight-bold);
44+
font-style: italic;
45+
}
46+
4247
.similarModes__cta {
4348
@include hard_button_base;
4449
margin-left: auto;

apps/fretonator-web/src/app/pages/learn/learn-index/learn-index.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<div class="learn__container">
44
<h1 class="learn__title">Learn Guitar Theory</h1>
5+
<h2 class="learn__subtitle">Fretonator Learning Hub</h2>
56
<p class="learn__introCopy">Welcome to the Fretonator learning hub, where you can learn music theory tailored to the
67
guitar, guitar techniques and essential maintenance skills.</p>
78
<p class="learn__introCopy">We'll be adding new content regularly, so please keep checking back!</p>

apps/fretonator-web/src/app/pages/learn/learn-index/learn-index.component.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
@include content_title;
1313
}
1414

15+
.learn__subtitle {
16+
@include fretonator_section_title;
17+
}
18+
1519
.learn__introCopy {
1620
@include content_intro_copy;
1721
}

apps/fretonator-web/src/app/pages/learn/patterns-index/patterns-index.component.html

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
<app-stripe-banner></app-stripe-banner>
22

3+
34
<div class="patterns__container">
5+
<div class="breadcrumbs">
6+
<a [routerLink]="['/', 'learn']" class="breadcrumbs__link">
7+
Go back to the Learn Hub</a>
8+
</div>
49
<div class="patterns__intro">
510
<h1 class="patterns__title">Learn the 7 scale patterns on the guitar</h1>
611
</div>
@@ -14,20 +19,13 @@ <h5 class="patterns__subtitle">You only need to learn 7 patterns</h5>
1419
the fretboard,
1520
regardless of the starting note or mode.
1621
</p>
17-
<p class="patterns__copy">Use the fretboard below to explore the patterns of each mode (shown in black). Tap each mode
18-
above the
19-
fretboard to highlight the root position pattern for each mode. You'll notice that each pattern shifts over one or
20-
two frets, and the patterns overlap.</p>
21-
<p class="patterns__copy">You can also jam using the purple notes - they're all part of the same mode, just using
22-
different positions.</p>
23-
<p class="patterns__copy">This means that once you have learned the 7 patterns and how they fit together, you can
24-
play in any key and any mode across the whole fretboard.
25-
</p>
22+
<p class="patterns__copy">Use the fretboard below to explore the patterns of each mode (shown in black). Notice that
23+
each pattern is made of <span class="emphasis">3 notes per string</span>.</p>
2624
</div>
2725

2826

2927
<div class="patterns__container">
30-
<h5 class="patterns__smallTitle">Learn patterns</h5>
28+
<h5 class="patterns__smallTitle">Choose a pattern</h5>
3129

3230
<div class="chips">
3331
<button *ngFor="let mode of modeSelectors"
@@ -46,6 +44,14 @@ <h5 class="patterns__smallTitle">Learn patterns</h5>
4644
</div>
4745

4846
<div class="patterns__container">
47+
<p class="patterns__copy">Tap each mode above the fretboard to highlight the <span class="emphasis">root position pattern</span>
48+
for each mode.
49+
You'll notice that each pattern shifts up one or two frets, and the patterns overlap.</p>
50+
<p class="patterns__copy">You can also jam using the purple notes - they're all part of the same mode, just using
51+
different positions.</p>
52+
<p class="patterns__copy">Once you have learned the 7 patterns and how they fit together, <span class="emphasis">you can
53+
play in any key and any mode across the whole fretboard.</span>
54+
</p>
4955
<p class="patterns__copy">For example, you want to jam in C Mixolydian? Move the Mixolydian pattern to the 8th fret
5056
on the low E string (C) and the whole 7-mode pattern
5157
moves with it - you can now use all of those notes!</p>
@@ -54,7 +60,7 @@ <h5 class="patterns__smallTitle">Learn patterns</h5>
5460
</p>
5561
<p class="patterns__subtitle">This works for ANY key and ANY of the 7 modes.
5662
</p>
57-
<p class="patterns__copy">Try it out - Use the Fretonator on the home page and see how these patterns fit together.
63+
<p class="patterns__copy">Try it out! Use the Fretonator on the home page and see how these patterns fit together.
5864
You'll soon realise that there's a lot less to memorise than you think!
5965
</p>
6066
<p class="patterns__copy">If you want to write some songs using these modes, check out the chords that work with
@@ -67,8 +73,8 @@ <h5 class="patterns__smallTitle">Learn patterns</h5>
6773
</div>
6874

6975
<div class="patterns__container">
70-
<h2 class="patterns__subtitle">The theory behind the the standard modes</h2>
71-
<h3 class="patterns__copy">The 7 standard modes on the guitar are generated by starting on different notes of the
76+
<h2 class="patterns__subtitle">And finally: the theory behind the the standard modes</h2>
77+
<h3 class="patterns__copy">The 7 standard modes are generated by starting on different notes of the
7278
major scale (which is, in fact, called the Ionian mode).</h3>
7379
<div class="card">
7480
<h4 class="card__title">Modes of the major scale</h4>
@@ -119,4 +125,7 @@ <h5 class="card__title">A fun mnemonic</h5>
119125
</ol>
120126
<p class="patterns__copy">What other ways have you used to remember the order of the 7 modes of the major scale?</p>
121127
</div>
128+
<a [routerLink]="['/']"
129+
[state]="{scrollToTop: true}"
130+
class="patterns__cta">Return to the Fretonator</a>
122131
</div>

apps/fretonator-web/src/app/pages/learn/patterns-index/patterns-index.component.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@
33
@import '../../../../styles/typography';
44
@import '../../../../styles/content';
55

6+
.breadcrumbs {
7+
margin-top: pxToRem($grid-unit * 2);
8+
margin-bottom: pxToRem($grid-unit * 2);
9+
}
10+
11+
.breadcrumbs__link {
12+
@include text_link;
13+
}
14+
15+
.breadcrumbs__link__svg {
16+
color: inherit;
17+
}
18+
619
.patterns__container {
720
@include content_container;
821
margin-bottom: pxToRem($grid-unit * 6);

apps/fretonator-web/src/styles/_mixins.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
font-size: inherit;
2424
color: var(--grey);
2525
cursor: pointer;
26-
border-bottom: pxToRem(1) solid var(--grey);
26+
border-bottom: pxToRem(2) solid var(--grey);
2727
padding-bottom: pxToRem(1);
2828
transition: color 0.1s ease-in-out, border-color 0.1s ease-in-out;
2929

0 commit comments

Comments
 (0)