Skip to content

Commit 9de778f

Browse files
author
Salma Alam-Naylor
committed
Add numbers below fretboard
1 parent db582a1 commit 9de778f

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed

apps/fretonator-web/src/app/common/fretonator/fretboard/fretboard.component.html

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@
1515
</ng-container>
1616
</ng-template>
1717

18+
<ng-template #fretboardHelp>
19+
<ng-container *ngFor="let fret of frets">
20+
<span class="fretboard__help" [attr.data-fret]="fret"></span>
21+
</ng-container>
22+
</ng-template>
23+
1824
<div class="fretboard__toggle">
1925
<button class="fretboard__toggleButton fretboard__toggleButton--twelve"
2026
[class.fretboard__toggleButton--active]="fretMode === fretModes.twelve"
@@ -65,6 +71,13 @@
6571
[ngTemplateOutletContext]="{ stringName: 'E', string: 'E' }"
6672
></ng-container>
6773
</div>
74+
75+
<div class="fretboard"
76+
[class.fretboard__24]="fretMode === fretModes.twentyFour">
77+
<ng-container
78+
[ngTemplateOutlet]="fretboardHelp"
79+
></ng-container>
80+
</div>
6881
</div>
6982

7083
<h4 class="fretonator__playCta">

apps/fretonator-web/src/app/common/fretonator/fretboard/fretboard.component.scss

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,32 @@
2020
}
2121
}
2222

23+
.fretboard__help {
24+
text-align: center;
25+
padding-top: pxToRem($grid-unit * 4);
26+
27+
&[data-fret="3"],
28+
&[data-fret="5"],
29+
&[data-fret="7"],
30+
&[data-fret="9"],
31+
&[data-fret="12"],
32+
&[data-fret="15"],
33+
&[data-fret="17"],
34+
&[data-fret="19"],
35+
&[data-fret="21"],
36+
&[data-fret="24"] {
37+
&:after {
38+
content: attr(data-fret);
39+
font-family: var(--font-family-main);
40+
font-style: italic;
41+
font-weight: var(--font-weight-bold);
42+
color: var(--grey);
43+
font-size: pxToRem(14);
44+
opacity: 0.5;
45+
}
46+
}
47+
}
48+
2349
.fretboard__24 {
2450
.fretboard__cell {
2551
&:nth-child(-n + 13) {
@@ -377,7 +403,7 @@
377403
display: flex;
378404
justify-content: center;
379405
align-items: center;
380-
margin-top: pxToRem($grid-unit * 4);
406+
margin-bottom: pxToRem($grid-unit * 2);
381407
color: var(--grey);
382408
line-height: 1;
383409
margin-left: auto;

0 commit comments

Comments
 (0)