Skip to content

Commit fdb559c

Browse files
author
Salma Alam-Naylor
committed
Don't show 'did you know' for theoretical scales
1 parent c4c46e7 commit fdb559c

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

apps/fretonator-web/src/app/common/fretonator/fretonator.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@ <h4 class="fretonator__playCta">
8787
<app-chord-map [chordMap]="chordMap"></app-chord-map>
8888

8989
<app-similar-modes [modeDisplayString]="modeDisplayString"
90-
[similarModes]="modeMap | getSimilarModes : mode">
90+
[similarModes]="modeMap | getSimilarModes : mode"
91+
[isTheoretical]="modeMap | isTheoreticalScale">
9192

9293
</app-similar-modes>
9394

apps/fretonator-web/src/app/common/fretonator/similar-modes/similar-modes.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="similarModes" *ngIf="similarModes.length > 0">
1+
<div class="similarModes" *ngIf="similarModes.length > 0 && !isTheoretical">
22
<h4 class="similarModes__title">Did you know?</h4>
33
<p class="similarModes__copy">If you know the patterns of {{modeDisplayString}} on the fretboard,
44
you can transfer those shapes to the modes below.</p>

apps/fretonator-web/src/app/common/fretonator/similar-modes/similar-modes.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ import { SimilarModes } from '../../../util/types';
99
export class SimilarModesComponent {
1010
@Input() similarModes: SimilarModes;
1111
@Input() modeDisplayString: string;
12+
@Input() isTheoretical: boolean;
1213
}

0 commit comments

Comments
 (0)