Merge pull request #48 from whyhow-ai/bug-replace-remove

Removing replace rule

Author: tomsmoker

backend/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Added
+
+- Graceful failure of triple export when no chunks are found
+
 ## [v0.1.5] - 2024-10-29
 
 ### Changed

backend/src/app/api/v1/endpoints/graph.py

@@ -106,26 +106,38 @@ async def export_triples(
     columns_dict = {item.id: item for item in request.columns}
     for row in request.rows:
         for key, value in row.cells.items():
-            converted_cells.append(
-                TableCell(
-                    answer={
-                        "answer": value,
-                        "document_id": (
-                            row.sourceData.document.id
-                            if hasattr(row.sourceData, "document")
-                            and hasattr(row.sourceData.document, "id")
-                            else ""
-                        ),
-                        "id": "",
-                        "prompt_id": "",
-                        "type": columns_dict[key].type,
-                        "chunks": request.chunks["-".join([row.id, key])],
-                    },
-                    columnId=key,
-                    dirty=False,
-                    rowId=row.id,
+            # Skip if value is not a string or is "None" or "none"
+            if not isinstance(value, str):
+                continue
+
+            # Remove any surrounding quotes and whitespace before checking
+            cleaned_value = value.strip().strip("\"'") if value else ""
+            if cleaned_value and cleaned_value.lower() != "none":
+                chunk_key = "-".join([row.id, key])
+                chunks = request.chunks.get(
+                    chunk_key, []
+                )  # Use .get() with default empty list
+
+                converted_cells.append(
+                    TableCell(
+                        answer={
+                            "answer": value,
+                            "document_id": (
+                                row.sourceData.document.id
+                                if hasattr(row.sourceData, "document")
+                                and hasattr(row.sourceData.document, "id")
+                                else ""
+                            ),
+                            "id": "",
+                            "prompt_id": "",
+                            "type": columns_dict[key].type,
+                            "chunks": chunks,
+                        },
+                        columnId=key,
+                        dirty=False,
+                        rowId=row.id,
+                    )
                 )
-            )
 
     try:
         table = Table(

frontend/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Changed
+
+- Removed replace rule as an option for now
+
 ## [v0.1.5] - 2024-10-29
 
 ### Added

frontend/src/components/kt/kt-controls/kt-global-rules.tsx

@@ -125,8 +125,8 @@ export function KTGlobalRules(props: BoxProps) {
                 must_return,"red,blue,green",Color
                 <br />
                 max_length,3,
-                <br />
-                replace,"blue,ultramarine,sapphire",Color
+                {/* <br />
+                replace,"blue,ultramarine,sapphire",Color */}
               </Code>
             </Box>
           </Group>
@@ -247,7 +247,8 @@ export function KTGlobalRules(props: BoxProps) {
 
 const csvJsonSchema = z.array(
   z.object({
-    rule_type: z.enum(["must_return", "may_return", "max_length", "replace"]),
+    // rule_type: z.enum(["must_return", "may_return", "max_length", "replace"]),
+    rule_type: z.enum(["must_return", "may_return", "max_length"]),
     value: z.string(),
     entity_type: z.string().optional()
   })

frontend/src/config/store/store.types.ts

@@ -98,7 +98,8 @@ export interface AnswerTableGlobalRule extends AnswerTableRule {
 }
 
 export interface AnswerTableRule {
-  type: "must_return" | "may_return" | "max_length" | "replace";
+  // type: "must_return" | "may_return" | "max_length" | "replace";
+  type: "must_return" | "may_return" | "max_length";
   options?: string[];
   length?: number;
 }

frontend/src/config/store/store.utils.ts

@@ -80,7 +80,7 @@ export const defaultRules: Record<AnswerTableRule["type"], AnswerTableRule> = {
   must_return: { type: "must_return", options: [] },
   may_return: { type: "may_return", options: [] },
   max_length: { type: "max_length", length: 1 },
-  replace: { type: "replace", options: [] }
+  // replace: { type: "replace", options: [] }
 };
 
 export const ruleOptions: {
@@ -90,14 +90,14 @@ export const ruleOptions: {
   { value: "must_return", label: "Must return" },
   { value: "may_return", label: "May return" },
   { value: "max_length", label: "Allowed # of responses" },
-  { value: "replace", label: "Replace" }
+  // { value: "replace", label: "Replace" }
 ];
 
 export const ruleInfo: Record<AnswerTableRule["type"], string> = {
   must_return: "The column must return the specified values",
   may_return: "The column may return the specified values",
   max_length: "The column must return at most N values",
-  replace: "Replace all specified values with the first one from the list"
+  // replace: "Replace all specified values with the first one from the list"
 };
 
 // Casting