Merge pull request #233 from whywaita/fix/232

whywaita · web-flow · commit 01396973a3a0 · 2025-06-25T12:58:34.000+09:00
Don't store error when ErrInvalidLabel
diff --git a/pkg/starter/starter.go b/pkg/starter/starter.go
@@ -223,6 +223,7 @@ func (s *Starter) ProcessJob(ctx context.Context, job datastore.Job) error {
 			if err := incrementDeleteJobMap(job); err != nil {
 				return fmt.Errorf("failed to increment delete metrics: %w", err)
 			}
+			return nil
 		}
 
 		if err := datastore.UpdateTargetStatus(ctx, s.ds, job.TargetID, datastore.TargetStatusErr, fmt.Sprintf("failed to create an instance (job ID: %s)", job.UUID)); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,7 @@ func (s *Starter) ProcessJob(ctx context.Context, job datastore.Job) error {`
`223`	`223`	`if err := incrementDeleteJobMap(job); err != nil {`
`224`	`224`	`return fmt.Errorf("failed to increment delete metrics: %w", err)`
`225`	`225`	`}`
	`226`	`+ return nil`
`226`	`227`	`}`
`227`	`228`
`228`	`229`	`if err := datastore.UpdateTargetStatus(ctx, s.ds, job.TargetID, datastore.TargetStatusErr, fmt.Sprintf("failed to create an instance (job ID: %s)", job.UUID)); err != nil {`