Merge pull request #204 from whywaita/refactor/logging-deprecated

whywaita · web-flow · commit cbe7edaf8e54 · 2024-05-14T01:02:48.000+09:00
Logging deprecated usage
diff --git a/pkg/config/init.go b/pkg/config/init.go
@@ -67,6 +67,11 @@ func LoadWithDefault() Conf {
 		if mwt == ModeWebhookTypeUnknown {
 			log.Panicf("%s is invalid webhook type", os.Getenv(EnvModeWebhookType))
 		}
+
+		if mwt == ModeWebhookTypeCheckRun {
+			log.Println("WARNING: check_run is deprecated mode and will delete it. Please use workflow_job")
+		}
+
 		c.ModeWebhookType = mwt
 	}
 
diff --git a/pkg/runner/runner.go b/pkg/runner/runner.go
@@ -111,6 +111,7 @@ func GetRunnerTemporaryMode(runnerVersion string) (string, TemporaryMode, error)
 	}
 
 	if ephemeralSupportVersion.GreaterThan(inputVersion) {
+		logger.Logf(false, "WARNING: runner version is lower than v2.282.0, use --once mode. It's deprecated. will be removed in future.")
 		return runnerVersion, TemporaryOnce, nil
 	}
 	return runnerVersion, TemporaryEphemeral, nil

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,11 @@ func LoadWithDefault() Conf {`
`67`	`67`	`if mwt == ModeWebhookTypeUnknown {`
`68`	`68`	`log.Panicf("%s is invalid webhook type", os.Getenv(EnvModeWebhookType))`
`69`	`69`	`}`
	`70`	`+`
	`71`	`+ if mwt == ModeWebhookTypeCheckRun {`
	`72`	`+ log.Println("WARNING: check_run is deprecated mode and will delete it. Please use workflow_job")`
	`73`	`+ }`
	`74`	`+`
`70`	`75`	`c.ModeWebhookType = mwt`
`71`	`76`	`}`
`72`	`77`
Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,7 @@ func GetRunnerTemporaryMode(runnerVersion string) (string, TemporaryMode, error)`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`if ephemeralSupportVersion.GreaterThan(inputVersion) {`
	`114`	`+ logger.Logf(false, "WARNING: runner version is lower than v2.282.0, use --once mode. It's deprecated. will be removed in future.")`
`114`	`115`	`return runnerVersion, TemporaryOnce, nil`
`115`	`116`	`}`
`116`	`117`	`return runnerVersion, TemporaryEphemeral, nil`