Rebase on main and fix rubocop offenses

Co-authored-by: ka8725 <243846+ka8725@users.noreply.github.com>

Author: Copilot

Gemfile.lock

@@ -89,7 +89,7 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    ast (2.4.2)
+    ast (2.4.3)
     base64 (0.1.1)
     bigdecimal (3.1.4)
     builder (3.2.4)
@@ -143,13 +143,13 @@ GEM
     nokogiri (1.15.4-x86_64-linux)
       racc (~> 1.4)
     parallel (1.23.0)
-    parser (3.2.2.4)
+    parser (3.3.10.1)
       ast (~> 2.4.1)
       racc
     prism (1.8.0)
     psych (5.1.1.1)
       stringio
-    racc (1.7.3)
+    racc (1.8.1)
     rack (3.0.8)
     rack-session (2.0.0)
       rack (>= 3.0.0)

lib/actual_db_schema/migration_context.rb

@@ -31,10 +31,10 @@ def configs
     end
 
     def filter_configs(all_configs)
-      all_configs.select do |db_config|
+      all_configs.reject do |db_config|
         # Skip if database is in the excluded list
         db_name = db_config.respond_to?(:name) ? db_config.name.to_sym : :primary
-        !ActualDbSchema.config.excluded_databases.include?(db_name)
+        ActualDbSchema.config.excluded_databases.include?(db_name)
       end
     end
 

test/test_database_filtering.rb

@@ -21,17 +21,17 @@
       utils.reset_database_yml(db_config)
       ActiveRecord::Base.configurations = { "test" => db_config }
       ActiveRecord::Tasks::DatabaseTasks.database_configuration = { "test" => db_config }
-      
+
       # Configure to exclude secondary database
       ActualDbSchema.config.excluded_databases = [:secondary]
-      
+
       # Get the migration context instance
       context = ActualDbSchema::MigrationContext.instance
-      
+
       # Verify only primary database is included
       configs = context.send(:configs)
       config_names = configs.map { |c| c.respond_to?(:name) ? c.name.to_sym : :primary }
-      
+
       assert_includes config_names, :primary
       refute_includes config_names, :secondary
     end
@@ -46,21 +46,21 @@
           "migrations_paths" => Rails.root.join("db", "migrate_queue").to_s
         }
       }
-      
+
       utils.reset_database_yml(db_config)
       ActiveRecord::Base.configurations = { "test" => db_config }
       ActiveRecord::Tasks::DatabaseTasks.database_configuration = { "test" => db_config }
-      
+
       # Configure to exclude secondary and queue databases
-      ActualDbSchema.config.excluded_databases = [:secondary, :queue]
-      
+      ActualDbSchema.config.excluded_databases = %i[secondary queue]
+
       # Get the migration context instance
       context = ActualDbSchema::MigrationContext.instance
-      
+
       # Verify only primary database is included
       configs = context.send(:configs)
       config_names = configs.map { |c| c.respond_to?(:name) ? c.name.to_sym : :primary }
-      
+
       assert_includes config_names, :primary
       refute_includes config_names, :secondary
       refute_includes config_names, :queue
@@ -71,13 +71,13 @@
       utils.reset_database_yml(db_config)
       ActiveRecord::Base.configurations = { "test" => db_config }
       ActiveRecord::Tasks::DatabaseTasks.database_configuration = { "test" => db_config }
-      
+
       ActualDbSchema.config.excluded_databases = []
-      
+
       context = ActualDbSchema::MigrationContext.instance
       configs = context.send(:configs)
       config_names = configs.map { |c| c.respond_to?(:name) ? c.name.to_sym : :primary }
-      
+
       assert_includes config_names, :primary
       assert_includes config_names, :secondary
     end
@@ -86,49 +86,49 @@
   describe "environment variable ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES" do
     it "parses comma-separated database names from environment variable" do
       ENV["ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES"] = "queue,cable"
-      
+
       # Create a new configuration to pick up the env var
       config = ActualDbSchema::Configuration.new
-      
-      assert_equal [:queue, :cable], config.excluded_databases
+
+      assert_equal %i[queue cable], config.excluded_databases
     ensure
       ENV.delete("ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES")
     end
 
     it "handles whitespace in environment variable" do
       ENV["ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES"] = "queue, cable, cache"
-      
+
       config = ActualDbSchema::Configuration.new
-      
-      assert_equal [:queue, :cable, :cache], config.excluded_databases
+
+      assert_equal %i[queue cable cache], config.excluded_databases
     ensure
       ENV.delete("ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES")
     end
 
     it "returns empty array when environment variable is not set" do
       ENV.delete("ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES")
-      
+
       config = ActualDbSchema::Configuration.new
-      
+
       assert_equal [], config.excluded_databases
     end
 
     it "handles empty string in environment variable" do
       ENV["ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES"] = ""
-      
+
       config = ActualDbSchema::Configuration.new
-      
+
       assert_equal [], config.excluded_databases
     ensure
       ENV.delete("ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES")
     end
 
     it "filters out empty values from comma-separated list" do
       ENV["ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES"] = "queue,,cable,  ,cache"
-      
+
       config = ActualDbSchema::Configuration.new
-      
-      assert_equal [:queue, :cable, :cache], config.excluded_databases
+
+      assert_equal %i[queue cable cache], config.excluded_databases
     ensure
       ENV.delete("ACTUAL_DB_SCHEMA_EXCLUDED_DATABASES")
     end