Ability to disable commands

[CyJimmy264]

Why not to do something like that here:

actual_db_schema/lib/actual_db_schema/commands/base.rb

Line 14 in 2442e83

unless ActualDbSchema.config.fetch(:enabled, true)

        call_impl if ActualDbSchema.config.fetch(:enabled, true)

[ka8725]

@CyJimmy264 Thanks for adding the issue! The exception was intentionally chosen to indicate that the tool is not functioning with the current setup. In contrast, the suggested implementation by yours would simply exit silently, which might give the impression that the tool is working when it’s not.

Both approaches have their pros and cons. If you can share more specifics about the issue, it will help us determine the best way to proceed and find a suitable solution. Looking forward to your input — thanks!

[CyJimmy264]

I've got a Docker development environment, with a Rails app there, but no .git.

When it boots with available data migrations (ilyakatz/data-migrate) ActualDbSchema commands are triggered somehow.

For example:

== 20230208122902 UpdateAdvertisementName: migrating ==========================
== 20230208122902 UpdateAdvertisementName: migrated (0.0513s) =================

fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

I tried to disable it.

Made a better workaround with an additional condition in the Gemfile:

group :development do
  gem 'actual_db_schema' if ENV['BUNDLE_PATH'].to_s.empty?

So now the problem has been solved.

[CyJimmy264]

Nah... that's not appropriate. It rewrites Gemfile.lock then)

Just to suppress these distracting messages, I've added 2>/dev/null to git command here 😄 :

CyJimmy264@848abcb#diff-1cdd9def99285cffb836edd948932ff18c7cd8c92ce388dc45cb64f56856e275R7

  # lib/actual_db_schema/git.rb
  # ...
  # Git helper
  class Git
    def self.current_branch
     `git rev-parse --abbrev-ref HEAD 2>/dev/null`.strip
 
    rescue Errno::ENOENT
 
      "unknown"
 
    end

[ka8725]

@CyJimmy264, it's a good fix. If I patch the gem so that it works even if it's not a git repo, would that work for you?

[ka8725]

@CyJimmy264 we've just released this fix - https://github.com/widefix/actual_db_schema/releases/tag/v0.8.5 please let me know if you still have any issues with the gem. Thanks for your feedback again!