Merge pull request #303 from Cherisher/patch-1

benoitg · web-flow · commit d7b9a21514fa · 2019-04-16T09:50:51.000-04:00
fixed get_ext_iface
diff --git a/src/util.c b/src/util.c
@@ -254,7 +254,7 @@ get_ext_iface(void)
         }
         while (!feof(input)) {
             /* XXX scanf(3) is unsafe, risks overrun */
-            if ((fscanf(input, "%15s %*s %15s %*s %*s %*s %*s %*s %*s %*s %*s\n", device, gw) == 2)
+            if ((fscanf(input, "%15s %15s %*s %*s %*s %*s %*s %*s %*s %*s %*s\n", device, gw) == 2)
                 && strcmp(gw, "00000000") == 0) {
                 free(gw);
                 debug(LOG_INFO, "get_ext_iface(): Detected %s as the default interface after trying %d", device, i);

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ get_ext_iface(void)`
`254`	`254`	`}`
`255`	`255`	`while (!feof(input)) {`
`256`	`256`	`/* XXX scanf(3) is unsafe, risks overrun */`
`257`		`- if ((fscanf(input, "%15s %s %15s %s %s %s %s %s %s %s %*s\n", device, gw) == 2)`
	`257`	`+ if ((fscanf(input, "%15s %15s %s %s %s %s %s %s %s %s %*s\n", device, gw) == 2)`
`258`	`258`	`&& strcmp(gw, "00000000") == 0) {`
`259`	`259`	`free(gw);`
`260`	`260`	`debug(LOG_INFO, "get_ext_iface(): Detected %s as the default interface after trying %d", device, i);`