Chore: ESLint 9 config, ES2017 compatibility, remove JSHint; rename lint script

Author: In1quity

eslint.config.js

@@ -1,7 +1,7 @@
 export default [
 	{
 		languageOptions: {
-			ecmaVersion: 2018,
+			ecmaVersion: 2017,
 			sourceType: "module",
 			globals: {
 				Atomics: "readonly",

package-lock.json

@@ -7,10 +7,9 @@
   "browser": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "lint:es5": "jshint index.js",
-    "lint:es6": "eslint index.js \"rater-src/**\"",
+    "lint:eslint": "eslint index.js \"rater-src/**\"",
     "lint:fix": "eslint index.js \"rater-src/**\" --fix",
-    "lint": "npm run lint:es6 && npm run lint:es5",
+    "lint": "npm run lint:eslint",
     "build:bundle": "browserify rater-src/App.js --debug -t babelify --outfile dist/rater.js",
     "build:minify": "uglifyjs dist/rater.js --compress -b ascii_only=true,beautify=false --output dist/rater.min.js",
     "build:concat": "concat-cli -f \"comment-top.js\" dist/rater.min.js \"comment-bottom.js\" -o dist/rater.min.js",

package.json

@@ -91,7 +91,7 @@ Template.prototype.getTitle = function() {
  *  rather than just top-level templates. 
  * @return {Template[]} templates
 */
-var parseTemplates = function(wikitext, recursive) { /* eslint-disable no-control-regex */
+var parseTemplates = function(wikitext, recursive) {
 	if (!wikitext) {
 		return [];
 	}
@@ -227,7 +227,7 @@ var parseTemplates = function(wikitext, recursive) { /* eslint-disable no-contro
 	}
 
 	return result; 
-}; /* eslint-enable no-control-regex */
+};
 
 /**
  * @param {Template|Template[]} templates

rater-src/Template.js

@@ -243,11 +243,9 @@ function BannerWidget( template, config ) {
 		allowSuggestionsWhenEmpty: true,
 		$overlay: this.$overlay
 	});
-	this.addParameterButton = new OO.ui.ButtonWidget({
-		...BannerWidget.staticElements.addButton,
-		icon: "add",
-		flags: "progressive"
-	}).setDisabled(true);
+	this.addParameterButton = new OO.ui.ButtonWidget(
+		Object.assign({}, BannerWidget.staticElements.addButton, { icon: "add", flags: "progressive" })
+	).setDisabled(true);
 	this.addParameterControls = new HorizontalLayoutWidget( {
 		items: [
 			this.addParameterNameInput,

rater-src/Windows/Components/BannerWidget.js

@@ -13,10 +13,8 @@ function HorizontalLayoutWidget( config ) {
 	// Call parent constructor
 	HorizontalLayoutWidget.super.call( this, {} );
 
-	this.layout = new OO.ui.HorizontalLayout( {
-		...config,
-		$element: this.$element
-	});
+	var cfg = Object.assign({}, config, { $element: this.$element });
+	this.layout = new OO.ui.HorizontalLayout( cfg );
 
 }
 OO.inheritClass( HorizontalLayoutWidget, OO.ui.Widget );

rater-src/Windows/Components/HorizontalLayoutWidget.js

@@ -19,7 +19,7 @@ function ParameterWidget( parameter, paramData, config ) {
 	this.isSuggested = this.paramData.suggested;
 
 	// Make a checkbox if only 1 or 2 allowed values
-	switch(this.allowedValues.length) {	/* eslint-disable no-fallthrough */
+	switch(this.allowedValues.length) {
 	case 1:
 		this.allowedValues[1] = null;
 		/* fall-through */
@@ -41,7 +41,7 @@ function ParameterWidget( parameter, paramData, config ) {
 		break;
 	default:
 			// No checkbox
-	} /* eslint-enable no-fallthrough */
+	}
 
 	/* --- EDIT PARAMETER LAYOUT --- */
 

rater-src/Windows/Components/ParameterWidget.js

@@ -602,7 +602,6 @@ MainWindow.prototype.onSearchSelect = function(data) {
 			"{{" + mw.html.escape(name) + "}} is not a recognised WikiProject banner.<br/>Do you want to continue?"
 		);
 	} else if (name === "WikiProject Disambiguation" && $("#ca-talk.new").length !== 0 && this.bannerList.items.length === 0) {
-		// eslint-disable-next-line no-useless-escape
 		confirmText = "New talk pages shouldn't be created if they will only contain the \{\{WikiProject Disambiguation\}\} banner. Continue?";
 	}
 	$.when( confirmText ? OO.ui.confirm(confirmText) : true)
@@ -670,7 +669,7 @@ MainWindow.prototype.transformTalkWikitext = function(talkWikitext) {
 	// replace insertion point (first control character) with a different control character
 	talkWikitext = talkWikitext.replace("\x01", "\x02");
 	// remove other control characters
-	/* eslint-disable-next-line no-control-regex */
+
 	talkWikitext = talkWikitext.replace(/(?:\s|\n)*\x01(?:\s|\n)*/g,"");
 	// split into wikitext before/after the remaining control character (and trim each section)
 	var talkWikitextSections = talkWikitext.split("\x02").map(t => t.trim());

rater-src/Windows/MainWindow.js

@@ -23,7 +23,9 @@ const write = function(key, val, staleDays, expiryDays) {
 			expiryDate: new Date(Date.now() + expiryDuration).toISOString()
 		});
 		localStorage.setItem("Rater-"+key, stringVal);
-	}  catch(e) {} // eslint-disable-line no-empty
+	}  catch (e) {
+		// Ignore storage errors (e.g., quota exceeded or unavailable)
+	}
 };
 /** read
  * @param {String} key

rater-src/cache.js

@@ -223,7 +223,7 @@ var setupRater = function(clickEvent) {
 				isArticle: subjectIsArticle
 			};
 			if (subjectPageCheck) {
-				result = { ...result, ...subjectPageCheck };
+				result = Object.assign({}, result, subjectPageCheck);
 			}
 			if (oresPredicition && subjectPageCheck && !subjectPageCheck.isGA && !subjectPageCheck.isFA && !subjectPageCheck.isFL) {
 				result.ores = oresPredicition;