Add clickable list for overriding event platform URI (#6159)

Co-authored-by: William Rai <[email protected]>

Author: cooltey

app/src/main/java/org/wikipedia/dataclient/ServiceFactory.kt

@@ -35,7 +35,7 @@ object ServiceFactory {
     })
 
     private val ANALYTICS_REST_SERVICE_CACHE = lruCache<DestinationEventService, EventService>(SERVICE_CACHE_SIZE, create = {
-        val intakeBaseUriOverride = Prefs.eventPlatformIntakeUriOverride.ifEmpty { it.baseUri }
+        val intakeBaseUriOverride = Prefs.eventPlatformIntakeUriOverride.orEmpty().ifEmpty { it.baseUri }
         createRetrofit(null, intakeBaseUriOverride).create<EventService>()
     })
 

app/src/main/java/org/wikipedia/settings/Prefs.kt

@@ -174,8 +174,9 @@ object Prefs {
     val mediaWikiBaseUriSupportsLangCode
         get() = PrefsIoUtil.getBoolean(R.string.preference_key_mediawiki_base_uri_supports_lang_code, true)
 
-    val eventPlatformIntakeUriOverride
-        get() = PrefsIoUtil.getString(R.string.preference_key_event_platform_intake_base_uri, "")!!
+    var eventPlatformIntakeUriOverride
+        get() = PrefsIoUtil.getString(R.string.preference_key_event_platform_intake_base_uri, "")
+        set(value) = PrefsIoUtil.setString(R.string.preference_key_event_platform_intake_base_uri, value)
 
     fun getLastRunTime(task: String): Long {
         return PrefsIoUtil.getLong(getLastRunTimeKey(task), 0)

app/src/main/java/org/wikipedia/settings/dev/DeveloperSettingsPreferenceLoader.kt

@@ -267,6 +267,12 @@ internal class DeveloperSettingsPreferenceLoader(fragment: PreferenceFragmentCom
                 true
             }
         }
+        (findPreference(R.string.preference_key_event_platform_intake_base_uri_list) as ListPreference).setOnPreferenceChangeListener { _, newValue ->
+            val selectedState = newValue as String
+            Prefs.eventPlatformIntakeUriOverride = selectedState
+            findPreference(R.string.preference_key_event_platform_intake_base_uri).summary = selectedState
+            true
+        }
     }
 
     private fun setUpMediaWikiSettings() {

app/src/main/res/values/dev_settings_strings.xml

@@ -37,7 +37,8 @@
     <string name="preferences_developer_suggested_edits_category">Suggested edits</string>
     <string name="preferences_developer_suggested_edits_reactivation_notification_stage_one">Show the first stage local notification for editor re-activation</string>
     <string name="preferences_developer_suggested_edits_reactivation_notification_stage_two">Show the second stage local notification for editor re-activation</string>
-    
+
+    <string name="preference_developer_event_platform_intake_base_uri_list_title">Event Platform intake base URI</string>
     <string name="preference_developer_event_platform_intake_base_uri_title">Override Event Platform intake base URI</string>
     <string name="preference_developer_send_event_platform_test_event_title">Send test event</string>
     <string name="preference_developer_send_event_platform_test_event_summary">Send a test event to the configured Event Platform intake endpoint</string>

app/src/main/res/values/preference_keys.xml

@@ -115,6 +115,7 @@
     <string name="preference_key_push_notification_options_set">pushNotificationOptionsSet</string>
     <string name="preference_key_event_platform_session_id">eventPlatformSessionId</string>
     <string name="preference_key_event_platform_intake_base_uri">eventPlatformIntakeBaseUri</string>
+    <string name="preference_key_event_platform_intake_base_uri_list">eventPlatformIntakeBaseUriList</string>
     <string name="preference_key_event_platform_stored_stream_configs">eventPlatformStoredStreamConfigs</string>
     <string name="preference_key_crash_report_local_class_name">crashReportLocalClassName</string>
     <string name="preference_key_watchlist_disabled_langs">watchlistDisabledLangs</string>

app/src/main/res/values/preference_values.xml

@@ -6,4 +6,12 @@
         <item>HEADERS</item>
         <item>BODY</item>
     </string-array>
+    <string-array name="preference_values_event_platform_intake_debug_titles">
+        <item>Production</item>
+        <item>Beta</item>
+    </string-array>
+    <string-array name="preference_values_event_platform_intake_debug_values">
+        <item>https://intake-analytics.wikimedia.org</item>
+        <item>https://intake-analytics-beta.wmflabs.org</item>
+    </string-array>
 </resources>

app/src/main/res/xml/developer_preferences.xml

@@ -86,6 +86,13 @@
             android:key="@string/preference_key_app_channel"
             android:title="@string/preference_key_app_channel" />
 
+        <ListPreference
+            android:key="@string/preference_key_event_platform_intake_base_uri_list"
+            android:title="@string/preference_developer_event_platform_intake_base_uri_list_title"
+            android:entries="@array/preference_values_event_platform_intake_debug_titles"
+            android:entryValues="@array/preference_values_event_platform_intake_debug_values"
+            android:summary="%s" />
+
         <org.wikipedia.settings.EditTextAutoSummarizePreference
             style="@style/DataStringPreference"
             android:key="@string/preference_key_event_platform_intake_base_uri"