Remove unused edit tags (#4259)

* Beginnings of Patroller task.

* Patroller Tasks: main "List of edits" screen (#4153)

* Initial commit

* Update viewModel and some preferences

* Add activity and waiting for the strings to be merged and updated

* Fix lint

* Update viewmodel with pagingsource

* Fix errors

* Set launchers

* Fix error

* Add suppress

* Add menu item clicks

* Add tags in list item

* Fix references

* Enchanced search functions

* Update filter group

* Fix error

* Add comment for filter implementation

* Use materialToolbar and use a proper icon

* Fix lint

* Replace the flag resource content

* Show user popup menu in the patroller tasks recent edits (#4160)

* Show user popup menu in the patroller tasks recent edits

* Set up dialog layout

* Set up dialog fragment and build viewModel for the dialog

* Add DateDiff function for the user information

* Update string format

* Update button visibility

* Update dialog wording and simplified the display

* Remove unused strings

* Update padding and text

* Patroller Tasks: Filters screen for List of Edits (#4176)

* Initial commit

* Update viewModel and some preferences

* Add activity and waiting for the strings to be merged and updated

* Fix lint

* Update viewmodel with pagingsource

* Fix errors

* Set launchers

* Fix error

* Add suppress

* Add menu item clicks

* Add tags in list item

* Fix references

* Enchanced search functions

* Update filter group

* Fix error

* Add comment for filter implementation

* Use materialToolbar and use a proper icon

* Fix lint

* Replace the flag resource content

* Initial commit

* Update item view and fix error

* Rename resource name

* Update filter layout

* Update filter type

* Adjust item layout padding and add checkbox logic back

* Update filter

* Update menu reset button visibility logic

* Update reset button code

* Add oresscore parameter to API call

* Fix lint

* Initial logic of filtering oresscores

* Fix launcher issue

* Fix lint

* Remove cache logic

* Filtering empty oresscore

* Initial spike of userinfo

* Add user experiences filter

* Update user information API

* Solified user experiences with user registration filter

* Remove comment

* Reduce redundant value

* Add cached logic for user info

* Simplified code

* Use updated method

* Fix lint

* Diff screen for Patroller Tasks. (#4209)

* Right.

Change-Id: I8577053379ec5844f179501ea85fd6b711315a95

* Update for current fragment structure.

Change-Id: Ia75b14b58123052cb6ac4bd101e887bca5ffdadf

* Update to latest state.

Change-Id: Idcea886de2bb869fe56916b521fbaf579ec2fe5f

* Switch to using plain recentedits API.

Change-Id: I41703258c375d1e48e2dd327f881cff5d24a7f2e

* Remove feature flag.

Change-Id: I3875a7f6f3352e20babd4abf57c9aa843d6f4bb6

* Finish proper merge.

Change-Id: I04e0d4bf7e50c2e16e91fb0911924da2ad3a623d

* Update.

Change-Id: I50c720d06fbff0196135e36e183d05d984980460

* Tighten up design.

Change-Id: I5461c0d55a307cffb39a7462d731e111dfed8e48

* Adapt to latest.

* Actually do it.

* Improve consistency of results.

* Reset cache if language has changed.

* Add service calls.

* Refactor with ViewModel.

* Refactor diff logic.

* Use refactored diff logic.

* Dial in a few more parameters.

* Add overflow options.

* Adapt.

* Adapt.

* Tweak.

* Use proper icons and text for suggested edits task.

* Begin adapting to current requirements.

* Introduce bottom bar.

* Transition undo button.

* Integrate ores scores from revisions.

* Begin re-molding the diff screen.

* Break out bespoke activity that holds a default diff fragment.

* Further adapt.

* Scroll correctly.

* Tweak.

* Fix diffs.

* Rearrange logic a bit.

* Tighten up.

* Init on resume.

* More in line with designs.

* Wire it up!

* Add reporting.

* Adapt.

* Correctly show user popup.

* Update style of Undo dialog.

* Fix qq error

* Design comments

* Use correct language code

* switch the thank visibility

---------

Co-authored-by: cooltey <[email protected]>

* Patroller tasks: build the screen for managing the warn templates (#4126)

* Adding required strings for the feature

* Add database and dao

* Add required stuffs, update db version and rename strings

* Fix lint

* Update AndroidManifest

* Fix error

* Add empty state illustration

* Add menu item

* Update item icon color

* Add new warn template xml and update resource name

* Rename ids

* Adding "add" activity for warn template

* Update resource and package names

* Remove license disclaimer

* Remove unused class

* Update TextInputDialog

* Complete add template logic

* Add request launcher to menu item

* Update list view of talk templates

* Update swappable class

* Update visibility settings

* Fix lint

* Update manifest, update db creation, and add temp access to templates

* Update illustration for empty state

* Update insert issue

* Complete drag behaviors

* Add an additional input field for editing template message

* Update edit dialog

* Update the update process

* Add a Input dialog for talk templates only

* Revert changes to basic text input dialog

* Rename function names

* Fix error

* Rename resource and add deletion process

* Update theme dialog button styles

* Tweaks to dialog text styles

* Update loading behavior to prevent reloading on device rotation

* Update list item

* A proper way of saving states of saving/deleting item

* Optimize views

* Add a new uistate for save and delete

* Update colors

* Design review update

* Fix lint

* Update with new wikitext keyboard

* Update dialog launcher

* Do not support wikitext keyboard in dialog

This reverts commit 1a8773d.

* Update invokeSource

* Update edittext string

* Update on correct position of list

* Add dismiss listener and add proper cancel action on AddTemplateActivity

* Update dialog text

* Add more logic of checking input field

* Fix lint

* Replace Quality with Damage and remove the inverted percentage (#4236)

* Create Onboarding for Patroller Tasks (#4208)

* Create Onboarding for Patroller Tasks

* Fix lint

* Fix issues and show the onboarding correctly

* Update preference and main screen tag

* Add sequential tooltips

* Add strings

* Add numbers for tooltips

* Add comment of possible issue

* Fix multiple tags issue

* Add data preference screen

* Add send data onboarding

* Fix lint

* Add feedback dialog layouts

* Add feedback dialog views

* Add comment for next step

* Quality to damage

* Update the timing of showing feedback form

* Add tooltips and feedback form

* Refine display logic

* Show feedback form after snackbar dismissed

* Set as non-cancelable

* Remove extra logic

* Update historyEntry constants

* Add Patroller Tasks related Rollback and Undo edit tags (#4242)

* Some code optimization

* Fix: empty message should only show if the filter count > 0 (#4244)

* Update snackbar messages and make the Undo button enabled by default (#4243)

* Patroller Tasks: update TalkReply activity to handle saved templates (#4239)

* Patroller Tasks: update TalkReply activity to handle saved templates

* Connect talk replay activity with diff screen

* Add checkbox and radio

* Add radio and checkbox logic

* Add percentage suffix for damage and intent

* Adding mutiple livedata

* Add the logic of handling template dialog

* Update message

* Update warn button listener

* Add spinner to reply interface

* Add onclick event

* integrate with dialog

* Solify logic of managing dialogs

* Remove comment

* Optimize stuff

* Update logic of managing template

* Remove testing button

* Minor design update

* Minor layout visibility update

* lint

* Make the dialog scrollable

* Replace radios to checkbox and optimze logic

* design comment

* Update input text error stauts

* Update the error text

* Patroller Tasks: show the bottom navigation bar after fully loaded

* Fix dialog checkbox end margin

* Fix: incorrect behavior after changing device orientation in Patrol edit (#4247)

* Fix: only inflate menu once in the ArticleeditDetailsFramgent

* Change .add to .replace to avoid adding multiple fragment

* Only commit fragment if there has no instance

* Adding Indonesian translations for Patroller tasks feature (#4250)

* Adding Indonesian translations for Patroller tasks feature

* Complete translations

---------

Co-authored-by: Sharvani Haran <[email protected]>

* Fix: Patroller Tasks user experience update (#4252)

* Fix: Patroller Tasks user experience update

* Wording

* Fix: Patroller Tasks input field error message (#4253)

* Fix: get correct feedback input source for Patroller Tasks (#4254)

* Data wiring: Patroller tasks (#4245)

* Data wiring: Patroller tasks

* Final wiring

* Fix: Multiple streams usage (#4248)

Co-authored-by: Sharvani Haran <[email protected]>

* More event updates

* Improvements to logging logic

* Simplify wikiId by using preferences

* Detect source for data events

* CR comments addressed

* Minor change

* Lint fix and minor update

* Minor change

* Swipe event added

---------

Co-authored-by: Sharvani Haran <[email protected]>

* Follow-up: Patroller Tasks data wiring (#4256)

* Data wiring for filter selection (#4255)

* Data wiring: Patroller tasks

* Final wiring

* Fix: Multiple streams usage (#4248)

Co-authored-by: Sharvani Haran <[email protected]>

* More event updates

* Improvements to logging logic

* Simplify wikiId by using preferences

* Detect source for data events

* CR comments addressed

* Minor change

* Lint fix and minor update

* Minor change

* Swipe event added

* Add data wiring to filter selection

* Minor change

---------

Co-authored-by: Sharvani Haran <[email protected]>

* Re-used some `in` translations (#4257)

Co-authored-by: Sharvani Haran <[email protected]>

* Minor code change

* Fix: set to default language code after updated in Patroller Tasks (#4258)

filter

* Unused tages

---------

Co-authored-by: Dmitry Brant <[email protected]>
Co-authored-by: Cooltey Feng <[email protected]>
Co-authored-by: cooltey <[email protected]>
Co-authored-by: Dmitry Brant <[email protected]>
Co-authored-by: Sharvani Haran <[email protected]>

Author: 4 people

app/src/main/java/org/wikipedia/descriptions/DescriptionEditFragment.kt

@@ -538,18 +538,13 @@ class DescriptionEditFragment : Fragment() {
         private const val SUGGESTED_EDITS_UI_VERSION = "1.0"
         const val MACHINE_SUGGESTION = "#machine-suggestion"
         const val MACHINE_SUGGESTION_MODIFIED = "#machine-suggestion-modified"
-        const val SUGGESTED_EDITS_ADD_COMMENT = "#suggestededit-add $SUGGESTED_EDITS_UI_VERSION"
-        const val SUGGESTED_EDITS_TRANSLATE_COMMENT = "#suggestededit-translate $SUGGESTED_EDITS_UI_VERSION"
-        const val SUGGESTED_EDITS_IMAGE_TAG_AUTO_COMMENT = "#suggestededit-imgtag-auto $SUGGESTED_EDITS_UI_VERSION"
-        const val SUGGESTED_EDITS_IMAGE_TAG_CUSTOM_COMMENT = "#suggestededit-imgtag-custom $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_PATROLLER_TASKS_ROLLBACK = "#suggestededit-patrol-rollback $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_PATROLLER_TASKS_UNDO = "#suggestededit-patrol-undo $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_ADD_DESC_COMMENT = "#suggestededit-add-desc $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_ADD_DESC_CHANGE_COMMENT = "#suggestededit-change-desc $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_TRANSLATE_DESC_COMMENT = "#suggestededit-translate-desc $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_ADD_CAPTION_COMMENT = "#suggestededit-add-caption $SUGGESTED_EDITS_UI_VERSION"
         const val SUGGESTED_EDITS_TRANSLATE_CAPTION_COMMENT = "#suggestededit-translate-caption $SUGGESTED_EDITS_UI_VERSION"
-        const val SUGGESTED_EDITS_ADD_TAG_COMMENT = "#suggestededit-add-tag $SUGGESTED_EDITS_UI_VERSION"
 
         private val DESCRIPTION_TEMPLATES = arrayOf("Short description", "SHORTDESC")
         // Don't remove the ending escaped `\\}`