Pass intent extras directly to OnThisDayFragment

Author: Isira-Seneviratne

app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayActivity.kt

@@ -6,16 +6,11 @@ import org.wikipedia.Constants
 import org.wikipedia.Constants.InvokeSource
 import org.wikipedia.activity.SingleFragmentActivity
 import org.wikipedia.dataclient.WikiSite
-import org.wikipedia.extensions.parcelableExtra
-import org.wikipedia.extensions.serializableExtra
 
 class OnThisDayActivity : SingleFragmentActivity<OnThisDayFragment>() {
 
     override fun createFragment(): OnThisDayFragment {
-        return OnThisDayFragment.newInstance(intent.getIntExtra(EXTRA_AGE, 0),
-            intent.parcelableExtra(Constants.ARG_WIKISITE)!!,
-            intent.getIntExtra(EXTRA_YEAR, -1),
-            intent.serializableExtra(Constants.INTENT_EXTRA_INVOKE_SOURCE)!!)
+        return OnThisDayFragment.newInstance(intent.extras!!)
     }
 
     companion object {

app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayFragment.kt

@@ -6,7 +6,6 @@ import android.view.View
 import android.view.ViewGroup
 import android.view.animation.AnimationUtils
 import androidx.appcompat.app.AppCompatActivity
-import androidx.core.os.bundleOf
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.Lifecycle
@@ -16,8 +15,6 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import com.google.android.material.tabs.TabLayoutMediator
 import kotlinx.coroutines.launch
-import org.wikipedia.Constants
-import org.wikipedia.Constants.InvokeSource
 import org.wikipedia.R
 import org.wikipedia.databinding.FragmentOnThisDayBinding
 import org.wikipedia.databinding.ViewEventsLayoutBinding
@@ -271,14 +268,9 @@ class OnThisDayFragment : Fragment(), CustomDatePicker.Callback {
         private const val VIEW_TYPE_ITEM = 0
         private const val VIEW_TYPE_FOOTER = 1
 
-        fun newInstance(age: Int, wikiSite: WikiSite, year: Int, invokeSource: InvokeSource): OnThisDayFragment {
+        fun newInstance(bundle: Bundle): OnThisDayFragment {
             return OnThisDayFragment().apply {
-                arguments = bundleOf(
-                    OnThisDayActivity.EXTRA_AGE to age,
-                    Constants.ARG_WIKISITE to wikiSite,
-                    OnThisDayActivity.EXTRA_YEAR to year,
-                    Constants.INTENT_EXTRA_INVOKE_SOURCE to invokeSource
-                )
+                arguments = bundle
             }
         }
     }