Remove 2024 Year-in-Review onboarding card (#6152)

Co-authored-by: Dmitry Brant <[email protected]>

Author: cooltey

app/src/main/java/org/wikipedia/feed/announcement/AnnouncementCardView.kt

@@ -10,10 +10,8 @@ import androidx.core.content.ContextCompat
 import androidx.core.text.method.LinkMovementMethodCompat
 import androidx.core.view.updateLayoutParams
 import org.wikipedia.R
-import org.wikipedia.analytics.eventplatform.BreadCrumbLogEvent
 import org.wikipedia.databinding.ViewCardAnnouncementBinding
 import org.wikipedia.feed.model.Card
-import org.wikipedia.feed.onboarding.YIROnboardingCard
 import org.wikipedia.feed.view.DefaultFeedCardView
 import org.wikipedia.util.DimenUtil
 import org.wikipedia.util.StringUtil
@@ -107,10 +105,6 @@ class AnnouncementCardView(context: Context) : DefaultFeedCardView<AnnouncementC
                     binding.viewAnnouncementContainer.radius = 0f
                 }
             }
-
-            if (value is YIROnboardingCard) {
-                BreadCrumbLogEvent.logImpression(context, "YIR2024")
-            }
         }
 
     private fun onPositiveActionClick() {

app/src/main/java/org/wikipedia/feed/model/CardType.kt

@@ -115,11 +115,6 @@ enum class CardType constructor(private val code: Int,
             return WikiGamesCardView(ctx)
         }
     },
-    YEAR_IN_REVIEW_ANNOUNCEMENT(96) {
-        override fun newView(ctx: Context): FeedCardView<*> {
-            return AnnouncementCardView(ctx)
-        }
-    },
     DAY_HEADER(97) {
         override fun newView(ctx: Context): FeedCardView<*> {
             return DayHeaderCardView(ctx)

app/src/main/java/org/wikipedia/feed/onboarding/OnboardingClient.kt

@@ -17,7 +17,6 @@ class OnboardingClient : FeedClient {
 
     private fun getCards(context: Context): List<Card> {
         val cards = ArrayList<Card>()
-        var card: OnboardingCard
 
         // NOTE: When adding new onboarding cards, please add them to the *beginning* of the list.
 
@@ -30,7 +29,7 @@ class OnboardingClient : FeedClient {
         //        if (card.shouldShow()) {
         //            cards.add(card);
         //        }
-        card = CustomizeOnboardingCard(
+        val card = CustomizeOnboardingCard(
             Announcement(id = "customizeOnboardingCard1",
                 text = context.getString(R.string.feed_configure_onboarding_text),
                 imageUrl = "https://upload.wikimedia.org/wikipedia/commons/3/3b/Announcement_header_for_Explore_Feed_customization.png",
@@ -42,19 +41,6 @@ class OnboardingClient : FeedClient {
             cards.add(card)
         }
 
-        card = YIROnboardingCard(
-            Announcement(id = "yir2024Card",
-                text = context.getString(R.string.year_in_review_text),
-                imageUrl = "https://upload.wikimedia.org/wikipedia/commons/2/21/WYiR_Block_1.gif",
-                action = Announcement.Action(context.getString(R.string.year_in_review_action_positive), "https://wikimediafoundation.org/wikipedia-year-in-review-2024/"),
-                negativeText = context.getString(R.string.view_announcement_card_negative_action),
-                imageAspectRatio = 4.0 / 3.0
-            )
-        )
-        if (card.shouldShow()) {
-            cards.add(card)
-        }
-
         return cards
     }
 

app/src/main/java/org/wikipedia/feed/onboarding/YIROnboardingCard.kt

@@ -200,13 +200,6 @@ internal class DeveloperSettingsPreferenceLoader(fragment: PreferenceFragmentCom
             setupLeakCanary()
             true
         }
-        findPreference(R.string.preference_key_feed_yir_onboarding_card_enabled).onPreferenceChangeListener = Preference.OnPreferenceChangeListener { _: Preference, isEnabled: Any? ->
-            if (isEnabled is Boolean && isEnabled) {
-                Prefs.hiddenCards = emptySet()
-                Toast.makeText(activity, "Please relaunch the app.", Toast.LENGTH_SHORT).show()
-            }
-            true
-        }
         findPreference(R.string.preference_key_otd_game_state).onPreferenceClickListener = Preference.OnPreferenceClickListener {
             Prefs.otdGameState = ""
             Toast.makeText(activity, "Game reset.", Toast.LENGTH_SHORT).show()

app/src/main/java/org/wikipedia/settings/dev/DeveloperSettingsPreferenceLoader.kt

@@ -71,7 +71,6 @@
     <string name="preference_key_feed_cards_lang_supported">feedCardsLangSupported</string>
     <string name="preference_key_feed_cards_lang_disabled">feedCardsLangDisabled</string>
     <string name="preference_key_feed_customize_onboarding_card_enabled">feedCustomizeOnboardingCardEnabled</string>
-    <string name="preference_key_feed_yir_onboarding_card_enabled">feedYirOnboardingCardEnabled</string>
     <string name="preference_key_add_articles">addArticles</string>
     <string name="preference_key_add_reading_lists">addReadingLists</string>
     <string name="preference_key_delete_reading_lists">deleteReadingLists</string>

app/src/main/res/values/preference_keys.xml

@@ -105,7 +105,4 @@
     <string name="diff_link_wikitext">{{{diffLink}}}</string>
     <string name="wikiText_replace_url">[[%1$s|%2$s]]</string>
 
-    <string name="year_in_review_action_positive">Take me there</string>
-    <string name="year_in_review_text"><![CDATA[<strong>Wikipedia 2024 Year in Review</strong><br/><br/>Wikipedia is the largest knowledge resource ever assembled in the history of the world, and it’s freely available to everyone everywhere. Here’s a review of 2024 through the lens of Wikipedia.]]></string>
-
 </resources>

app/src/main/res/values/strings_no_translate.xml

@@ -441,10 +441,6 @@
             android:title="Donation results"
             android:dialogMessage="Example: [{"dateTime":"2024-10-22T00:00:00.000"}]"/>
 
-        <org.wikipedia.settings.SwitchPreferenceMultiLine
-            android:key="@string/preference_key_feed_yir_onboarding_card_enabled"
-            android:title="Year-in-review Feed Card" />
-
         <org.wikipedia.settings.SwitchPreferenceMultiLine
             android:key="@string/preference_key_explore_feed_survey_shown"
             android:title="@string/preference_key_explore_feed_survey_shown"/>