Image recs: insert into infobox only for English. (#4679)

dbrant · cooltey · web-flow · commit d6e160120af5 · 2024-05-17T13:05:52.000-07:00
Co-authored-by: Cooltey Feng &lt;cfeng@wikimedia.org&gt;
diff --git a/app/src/main/java/org/wikipedia/edit/insertmedia/InsertMediaViewModel.kt b/app/src/main/java/org/wikipedia/edit/insertmedia/InsertMediaViewModel.kt
@@ -220,7 +220,10 @@ class InsertMediaViewModel(bundle: Bundle) : ViewModel() {
                 }
             }
 
-            if (autoInsert && attemptInfobox && infoboxMatch != null) {
+            // Verify a few conditions before attempting to insert into an infobox, including
+            // whether the infobox actually exists, and whether the current language wiki is
+            // supported by our hardcoded infoboxVars.
+            if (autoInsert && attemptInfobox && infoboxMatch != null && infoboxVarsByLang.containsKey(langCode)) {
                 val infoboxStartIndex = infoboxMatch.range.first
                 val infoboxEndIndex = infoboxMatch.range.last
 

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,10 @@ class InsertMediaViewModel(bundle: Bundle) : ViewModel() {`
`220`	`220`	`}`
`221`	`221`	`}`
`222`	`222`
`223`		`- if (autoInsert && attemptInfobox && infoboxMatch != null) {`
	`223`	`+ // Verify a few conditions before attempting to insert into an infobox, including`
	`224`	`+ // whether the infobox actually exists, and whether the current language wiki is`
	`225`	`+ // supported by our hardcoded infoboxVars.`
	`226`	`+ if (autoInsert && attemptInfobox && infoboxMatch != null && infoboxVarsByLang.containsKey(langCode)) {`
`224`	`227`	`val infoboxStartIndex = infoboxMatch.range.first`
`225`	`228`	`val infoboxEndIndex = infoboxMatch.range.last`
`226`	`229`