Setup mediawiki/mediawiki-phan-config

Use phan-suppress-next-line on a couple of lines where it needs
composer 1.x code; expect phan to be tested against composer 2.x.

Author: reedy

.github/workflows/php.yml

@@ -28,6 +28,7 @@ jobs:
       uses: shivammathur/setup-php@v2
       with:
         php-version: ${{ matrix.php-version }}
+        extensions: ast
         coverage: xdebug
         tools: composer:v2
 
@@ -48,6 +49,7 @@ jobs:
         dependency-versions: "${{ matrix.composer-dependencies }}"
 
     - run: composer test
+    - run: composer phan
 
   ocular-push:
     runs-on: ubuntu-latest

.phan/config.php

@@ -0,0 +1,22 @@
+<?php
+
+$cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';
+
+$cfg['directory_list'] = array_merge(
+	$cfg['directory_list'],
+	[
+		'vendor/composer/composer/src/Composer/',
+		'vendor/composer/semver/src/',
+
+	]
+);
+
+$cfg['exclude_analysis_directory_list'] = array_merge(
+	$cfg['exclude_analysis_directory_list'],
+	[
+		'vendor/composer/composer/src/Composer/',
+		'vendor/composer/semver/src/',
+	]
+);
+
+return $cfg;

composer.json

@@ -17,6 +17,7 @@
     },
     "require-dev": {
         "composer/composer": "^1.1||^2.0",
+        "mediawiki/mediawiki-phan-config": "0.10.6",
         "php-parallel-lint/php-parallel-lint": "~1.2.0",
         "phpunit/phpunit": "^8.5||^9.0",
         "squizlabs/php_codesniffer": "~3.5.8"
@@ -41,6 +42,7 @@
             "phpunit --log-junit=reports/unitreport.xml --coverage-text --coverage-html=reports/coverage --coverage-clover=reports/coverage.xml",
             "phpcs --encoding=utf-8 --standard=PSR2 --report-checkstyle=reports/checkstyle-phpcs.xml --report-full --extensions=php src/* tests/phpunit/*"
         ],
+        "phan": "phan -d . --long-progress-bar",
         "test": [
             "composer validate --no-interaction",
             "parallel-lint src tests",

src/MergePlugin.php

@@ -373,6 +373,8 @@ public function onPostInstallOrUpdate(ScriptEvent $event)
             $installer->setUpdate(true);
 
             if ($this->state->isComposer1()) {
+                // setUpdateWhitelist() only exists in composer 1.x. Configure as to run phan against composer 2.x
+                // @phan-suppress-next-line PhanUndeclaredMethod
                 $installer->setUpdateWhitelist($requirements);
             } else {
                 $installer->setUpdateAllowList($requirements);

src/MultiConstraint.php

@@ -36,6 +36,8 @@ class MultiConstraint extends SemverMultiConstraint
     public static function create(array $constraints, $conjunctive = true)
     {
         if (\count($constraints) === 0) {
+            // EmptyConstraint only exists in composer 1.x. Configure as to run phan against composer 2.x
+            // @phan-suppress-next-line PhanTypeMismatchReturn, PhanUndeclaredClassMethod
             return new EmptyConstraint();
         }