Skip to content

Commit 47afac0

Browse files
lucaswerkmeisterjenkins-bot
authored andcommitted
Disable vue/no-v-html rule in wbui2025 directory
The v-html directive is part of our expected workflow for reusing server-rendered HTML (property links, snak values; see the upcoming ADR of T399832). As such, this eslint rule is not currently useful for us. If eslint adds the ignorePattern (or similar) option suggested in [1], then we may later use it again (but note that this will require us to upgrade to the latest version of eslint-plugin-vue first). [1]: vuejs/eslint-plugin-vue#2857 Change-Id: I8926d09a67927dc36b0bd5cfdb3e5c6a7256842e
1 parent 024f6b5 commit 47afac0

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
'use-strict';
2+
3+
module.exports = {
4+
rules: {
5+
// disable this rule for now, as we use v-html= regularly;
6+
// can perhaps be reenabled with an ignorePattern later
7+
'vue/no-v-html': 'off'
8+
}
9+
};

repo/resources/wikibase.wbui2025/wikibase.wbui2025.mainSnak.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,12 @@
33
<div class="wikibase-rankselector ui-state-default">
44
<span class="ui-icon ui-icon-rankselector wikibase-rankselector-normal" title="Normal rank"></span>
55
</div>
6-
<!-- eslint-disable vue/no-v-html -->
76
<div
87
class="wikibase-wbui2025-snak-value"
98
:data-snak-hash="hash"
109
:class="snakValueClass"
1110
v-html="html"
1211
></div>
13-
<!-- eslint-enable -->
1412
</div>
1513
</template>
1614

repo/resources/wikibase.wbui2025/wikibase.wbui2025.propertyName.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
<template>
22
<div class="wikibase-wbui2025-property-name">
3-
<!-- eslint-disable vue/no-v-html -->
43
<p
54
class="wikibase-wbui2025-property-name-link"
65
:data-property-id="propertyId"
76
v-html="propertyLinkHtml"
87
></p>
9-
<!-- eslint-enable -->
108
</div>
119
</template>
1210

repo/resources/wikibase.wbui2025/wikibase.wbui2025.qualifiers.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@
77
<p>{{ qualifiersMessage }}</p>
88
<template v-for="snak in qualifiersOrder" :key="snak">
99
<template v-for="propertysnak in qualifiers[snak]" :key="propertysnak">
10-
<!-- eslint-disable vue/no-v-html -->
1110
<div
1211
class="wikibase-wbui2025-snak-value wikibase-wbui2025-qualifier"
1312
:data-snak-hash="propertysnak.hash"
1413
v-html="snakHtml( propertysnak )"
1514
></div>
16-
<!-- eslint-enable -->
1715
</template>
1816
</template>
1917
</div>

repo/resources/wikibase.wbui2025/wikibase.wbui2025.references.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,11 @@
1515
<template v-for="reference in references" :key="reference">
1616
<template v-for="snak in reference['snaks-order']" :key="snak">
1717
<template v-for="propertysnak in reference.snaks[snak]" :key="propertysnak">
18-
<!-- eslint-disable vue/no-v-html -->
1918
<div
2019
class="wikibase-wbui2025-snak-value"
2120
:data-snak-hash="propertysnak.hash"
2221
v-html="snakHtml( propertysnak )"
2322
></div>
24-
<!-- eslint-enable -->
2523
</template>
2624
</template>
2725
</template>

0 commit comments

Comments
 (0)