Merge pull request #5674 from wikimedia/history-title

Add History title to view

Author: mazevedofs

WMFComponents/Sources/WMFComponents/Components/History/WMFHistoryView.swift

@@ -160,8 +160,16 @@ public struct WMFHistoryView: View {
         ZStack {
             Color(theme.paperBackground)
                 .ignoresSafeArea()
+
             if !viewModel.isEmpty {
-                listView()
+                VStack(alignment: .leading, spacing: 8) {
+                    Text(viewModel.localizedStrings.historyHeaderTitle)
+                        .font(Font(WMFFont.for(.boldTitle3)))
+                        .foregroundStyle(Color(uiColor: theme.text))
+                        .padding(.horizontal)
+
+                    listView()
+                }
             } else {
                 emptyView()
             }

WMFComponents/Sources/WMFComponents/Components/History/WMFHistoryViewModel.swift

@@ -15,8 +15,9 @@ public final class WMFHistoryViewModel: ObservableObject {
         let unsaveActionTitle: String
         let shareActionTitle: String
         let deleteSwipeActionLabel: String
+        let historyHeaderTitle: String
 
-        public init(emptyViewTitle: String, emptyViewSubtitle: String, todayTitle: String, yesterdayTitle: String, openArticleActionTitle: String, saveForLaterActionTitle: String, unsaveActionTitle: String, shareActionTitle: String, deleteSwipeActionLabel: String) {
+        public init(emptyViewTitle: String, emptyViewSubtitle: String, todayTitle: String, yesterdayTitle: String, openArticleActionTitle: String, saveForLaterActionTitle: String, unsaveActionTitle: String, shareActionTitle: String, deleteSwipeActionLabel: String, historyHeaderTitle: String) {
             self.emptyViewTitle = emptyViewTitle
             self.emptyViewSubtitle = emptyViewSubtitle
             self.todayTitle = todayTitle
@@ -26,6 +27,7 @@ public final class WMFHistoryViewModel: ObservableObject {
             self.unsaveActionTitle = unsaveActionTitle
             self.shareActionTitle = shareActionTitle
             self.deleteSwipeActionLabel = deleteSwipeActionLabel
+            self.historyHeaderTitle = historyHeaderTitle
         }
     }
 

WMFComponents/Tests/WMFComponentsTests/WMFHistoryViewModelTests.swift

@@ -48,7 +48,8 @@ final class WMFHistoryViewModelTests: XCTestCase {
         saveForLaterActionTitle: "Save for Later",
         unsaveActionTitle: "Unsave",
         shareActionTitle: "Share",
-        deleteSwipeActionLabel: "Delete"
+        deleteSwipeActionLabel: "Delete",
+        historyHeaderTitle: "History"
     )
 
     func createViewModel(with controller: WMFHistoryDataControllerProtocol) -> WMFHistoryViewModel {

Wikipedia/Code/SearchViewController.swift

@@ -833,8 +833,7 @@ class SearchViewController: ThemeableViewController, WMFNavigationBarConfiguring
         let todayTitle = CommonStrings.todayTitle
         let yesterdayTitle = CommonStrings.yesterdayTitle
 
-        let localizedStrings = WMFHistoryViewModel.LocalizedStrings(emptyViewTitle: CommonStrings.emptyNoHistoryTitle, emptyViewSubtitle: CommonStrings.emptyNoHistorySubtitle, todayTitle: todayTitle, yesterdayTitle: yesterdayTitle, openArticleActionTitle: "Open article",saveForLaterActionTitle: CommonStrings.saveTitle, unsaveActionTitle: CommonStrings.unsaveTitle, shareActionTitle: CommonStrings.shareMenuTitle, deleteSwipeActionLabel: CommonStrings.deleteActionTitle)
-
+        let localizedStrings = WMFHistoryViewModel.LocalizedStrings(emptyViewTitle: CommonStrings.emptyNoHistoryTitle, emptyViewSubtitle: CommonStrings.emptyNoHistorySubtitle, todayTitle: todayTitle, yesterdayTitle: yesterdayTitle, openArticleActionTitle: "Open article",saveForLaterActionTitle: CommonStrings.saveTitle, unsaveActionTitle: CommonStrings.unsaveTitle, shareActionTitle: CommonStrings.shareMenuTitle, deleteSwipeActionLabel: CommonStrings.deleteActionTitle, historyHeaderTitle: CommonStrings.historyTabTitle)
 
         let viewModel = WMFHistoryViewModel(emptyViewImage: UIImage(named: "history-blank"), localizedStrings: localizedStrings, historyDataController: historyDataController)