Skip to content

Commit 700b76d

Browse files
authored
Merge pull request #5206 from wikimedia/article-coordinator-pt1
Clean out Article as a Living Document experiment code
2 parents dbc6481 + 58ba827 commit 700b76d

File tree

209 files changed

+3407
-13769
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

209 files changed

+3407
-13769
lines changed

WMF Framework/ABTestsController.swift

Lines changed: 0 additions & 123 deletions
This file was deleted.

WMF Framework/CommonStrings.swift

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -451,86 +451,6 @@ public class CommonStrings: NSObject {
451451

452452
@objc public static let donateTitle = WMFLocalizedString("settings-donate", value: "Donate", comment: "Link to donate")
453453

454-
// Article As A Living Doucment Strings - for some reason build script doesn't auto generate these when used directly in SignificantEventsViewModels.swift
455-
456-
public static let viewFullHistoryText = WMFLocalizedString("aaald-view-full-history-button", value: "View full article history", comment: "Text displayed in a button for pushing to the full article history view on the article as a living document screen.")
457-
458-
static let smallChangeDescription = WMFLocalizedString("aaald-small-change-description",
459-
value:"{{PLURAL:%1$d|0=No small changes made|%1$d small change made|%1$d small changes made}}",
460-
comment:"Describes how many small changes are batched together in the article as a living document timeline view. %1$d is replaced with the number of small changes.")
461-
462-
static let newTalkTopicDescriptionFormat = WMFLocalizedString("aaald-new-talk-topic-description-format", value: "%1$@ about this article", comment: "Title displayed in an article as a living document timeline cell and content insert explaining that a new article talk page topic has been posted. %1$@ is replaced by `New discussion` text.")
463-
static let newTalkTopicDiscussion = WMFLocalizedString("aaald-new-discussion", value: "New discussion", comment: "Portion of title displayed in article as a living document timeline cell and content insert explaining that a new article talk page topic has been posted.")
464-
465-
static let vandalismRevertDescription = WMFLocalizedString("aaald-vandalism-revert-description", value: "Suspected Vandalism reverted", comment: "Title displayed in an article as a living document timeline cell explaining that a vandalism revision was reverted.")
466-
467-
static let multipleChangesMadeDescription = WMFLocalizedString("aaald-multiple-changes-description", value: "Multiple changes made", comment: "Title displayed in article as a living document content insert explaining that multiple changes were made in a revision.")
468-
469-
static let addedTextDescription = WMFLocalizedString("aaald-added-text-description-2", value:"%1$@ added", comment:"Title displayed in an article as a living document cell explaining that a revision has a certain number of characters added. %1$@ is replaced by a formatted string representing characters added.")
470-
471-
static let deletedTextDescription = WMFLocalizedString("aaald-deleted-text-description-2", value:"%1$@ deleted", comment:"Title displayed in an article as a living document cell explaining that a revision has a certain number of characters deleted. %1$@ is replaced by a formatted string representing characters deleted.")
472-
473-
static let charactersTextDescription = WMFLocalizedString("aaald-characters-text-description", value:"{{PLURAL:%1$d|0=characters|character|characters}}",
474-
comment:"Displayed in an article as a living document cell explaining that a revision has a certain number of characters added or deleted. %1$d is the number of characters added or deleted.")
475-
476-
static let articleDescriptionUpdatedDescription = WMFLocalizedString("aaald-article-description-updated-description", value:"Article description updated",
477-
comment:"Title displayed in an article as a living document cell explaining that an article's description was updated in a revision.")
478-
479-
static let singleReferenceAddedDescription = WMFLocalizedString("aaald-single-reference-added-description", value:"Reference added",
480-
comment:"Title displayed in an article as a living document timeline cell when a reference was added (and no other changes) to a revision.")
481-
482-
static let multipleReferencesAddedDescription = WMFLocalizedString("aaald-multiple-references-added-description", value:"Multiple references added",
483-
comment:"Title displayed in an article as a living document cell when multiple references were added (and no other changes) to a revision.")
484-
485-
static let numericalMultipleReferencesAddedDescription = WMFLocalizedString("aaald-numerical-multiple-references-added-description", value:"{{PLURAL:%1$d|0=0 references|%1$d reference|%1$d references}} added",
486-
comment:"Title displayed in an article as a living document cell explaining that multiple references were added to a revision. This string is used alongside other changes types like added characters. %1$d is replaced with the number of references.")
487-
488-
static let oneSectionDescription = WMFLocalizedString("aaald-one-section-description", value: "in the %1$@ section", comment: "Text explaining what section an article as a living document event change occurred in, if occurred in only one section. %1$@ is replaced with the section name.")
489-
490-
static let twoSectionsDescription = WMFLocalizedString("aaald-two-sections-description", value: "in the %1$@ and %2$@ sections", comment: "Text explaining what sections an article as a living document event change occurred in, if occurred in two sections. %1$@ is replaced with the first section name, %2$@ with the second.")
491-
492-
static let manySectionsDescription = WMFLocalizedString("aaald-many-sections-description", value: "in %1$d sections", comment: "Text explaining what sections an article as a living document change occurred in, if occurred in 3+ sections. %1$d is replaced with the number of sections.")
493-
494-
static let newBookReferenceTitle = WMFLocalizedString("aaald-new-book-reference-title",
495-
value:"Book", comment: "Header text for a new book reference type that was added in an article as a living document cell.")
496-
497-
static let newJournalReferenceTitle = WMFLocalizedString("aaald-new-journal-reference-title",
498-
value:"Journal", comment: "Header text for a new journal reference type that was added in an article as a living document cell.")
499-
500-
static let newNewsReferenceTitle = WMFLocalizedString("aaald-new-news-reference-title",
501-
value:"News", comment: "Header text for a new news reference type that was added in an article as a living document cell.")
502-
503-
static let newWebsiteReferenceTitle = WMFLocalizedString("aaald-new-website-reference-title",
504-
value:"Website", comment: "Header text for a new website reference type that was added in an article as an living document cell.")
505-
506-
static let newJournalReferenceVolume = WMFLocalizedString("aaald-new-journal-reference-volume",
507-
value:"Volume %1$@:", comment: "Volume text for a new journal reference type that was added in an article as a living document cell. %1$@ is replaced by the journal volume number of the reference.")
508-
509-
static let newJournalReferenceDatabase = WMFLocalizedString("aaald-new-journal-reference-database",
510-
value:"via %1$@", comment: "Database text for a new journal reference type that was added in an article as a living document cell. %1$@ is replaced by the database volume number of the reference.")
511-
512-
static let newWebsiteReferenceArchiveUrlText = WMFLocalizedString("aaald-new-website-reference-archive-url-text",
513-
value:"Archive.org URL", comment: "Archive.org URL text for a new website reference type that was added in an article as a living document cell. This will be turned into a link that goes to the reference's Archive.org URL.")
514-
515-
static let newWebsiteReferenceArchiveDateText = WMFLocalizedString("aaald-new-website-reference-archive-date-text",
516-
value:"from the original on %1$@", comment: "Text in a new website reference in an article as a living document cell that describes when the reference was retrieved for Archive.org. %1$@ is replaced with the reference's archive date.")
517-
518-
static let newNewsReferenceRetrievedDate = WMFLocalizedString("aaald-new-news-reference-retrieved-date",
519-
value:"Retrieved %1$@", comment: "Retrieved date text for a new news reference type that was added in an article as a living document cell. %1$@ is replaced by the reference's retrieved date.")
520-
521-
// tonitodo: this fails with EXC_BADACCESS when I try to use plural edits
522-
static let revisionUserInfo = WMFLocalizedString(
523-
"aaald-revision-userInfo",
524-
value:"Edit by %1$@ (%2$@ edits)", comment: "Text describing details about the user that made a significant revision in the article as a living document view. %1$@ is replaced by the editor name and %2$d is replaced by the number of edits they have made.")
525-
526-
static let revisionUserInfoAnonymous = WMFLocalizedString("aaald-revision-by-anonymous",
527-
value:"Edit by anonymous user", comment: "Text describing the anonymous user that made a significant revision in the article as a living document view.")
528-
529-
static let articleAsLivingDocSummaryTitle = WMFLocalizedString(
530-
"aaald-summary-title",
531-
value:"{{PLURAL:%1$d|0=0 changes|%1$d change|%1$d changes}} by {{PLURAL:%2$d|0=0 editors|%2$d editor|%2$d editors}} in {{PLURAL:%3$d|0=0 days|%3$d day|%3$d days}}",
532-
comment:"Describes how many small changes are batched together in the article as a living document timeline view. %1$d is replaced by the number of accumulated changes editors made, %2$d is replaced by the number of editors that made that change and %3$d is replaced with relative timeframe date that the edit counting started (e.g. 10 days).")
533-
534454
@objc public static func onThisDayAdditionalEventsMessage(with languageCode: String?, locale: Locale, eventsCount: Int) -> String {
535455
return String(format: WMFLocalizedString("on-this-day-detail-header-title", languageCode: languageCode, value:"{{PLURAL:%1$d|%1$d historical event|%1$d historical events}}", comment:"Title for 'On this day' detail view - %1$d is replaced with the number of historical events which occurred on the given day"), locale: locale, eventsCount)
536456
}
@@ -540,9 +460,6 @@ public class CommonStrings: NSObject {
540460
public static func onThisDayFooterWith(with eventCount: Int, languageCode: String? = nil, locale: Locale = Locale.autoupdatingCurrent) -> String {
541461
return String(format: WMFLocalizedString("on-this-day-footer-showing-event-count", languageCode: languageCode, value: "{{PLURAL:%1$d|%1$d more historical event|%1$d more historical events}} on this day", comment: "Footer for presenting user option to see longer list of 'On this day' articles. %1$@ will be substituted with the number of events"), locale: locale, eventCount)
542462
}
543-
public static let articleAsLivingDocErrorTitle = WMFLocalizedString("aaald-error-title", value: "Unable to load inline article history", comment: "Title of error banner that appears at the bottom of an article when significant events fail to load.")
544-
545-
public static let articleAsLivingDocErrorSubtitle = WMFLocalizedString("aaald-error-subitle", value: "Refresh to try again", comment: "Subtitle of error banner that appears at the bottom of an article when significant events fail to load.")
546463

547464
// TODO: Delete this when we remove web editor code
548465
public static let editorExitConfirmationTitle = WMFLocalizedString("editor-exit-confirmation-title", value: "Dismiss the editing mode?", comment: "Title text of editing mode confirmation alert. Presented to the user when they they are about to be navigated away from the editor flow.")

0 commit comments

Comments
 (0)