Skip to content

Commit ef80f9f

Browse files
authored
Merge pull request #5739 from wikimedia/T416194
T416194: Fix compactness
2 parents 02139b1 + 28617a4 commit ef80f9f

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

WMFComponents/Sources/WMFComponents/Extensions/Navigation Bar/WMFNavigationBarHiding.swift

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,21 @@ public extension WMFNavigationBarHiding where Self:UIViewController {
7171
swapLogoToFull()
7272
}
7373
}
74+
75+
func resetLogoToFull() {
76+
WMFNavigationBarHidingLogoState.isCompact = false
77+
swapLogoToFull()
78+
}
79+
80+
func restoreLogoStateForCurrentScrollPosition(scrollView: UIScrollView) {
81+
let finalOffset = scrollView.contentOffset.y + scrollView.safeAreaInsets.top
82+
if finalOffset > 75 {
83+
WMFNavigationBarHidingLogoState.isCompact = false // reset so the guard passes
84+
updateLogoImageOnScroll(scrollView: scrollView)
85+
} else {
86+
resetLogoToFull()
87+
}
88+
}
7489

7590
private func swapLogoToCompact() {
7691
navigationItem.leftBarButtonItem?.image = UIImage(named: "W")

Wikipedia/Code/ExploreViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ class ExploreViewController: ColumnarCollectionViewController, ExploreCardViewCo
123123
}
124124

125125
override func viewWillAppear(_ animated: Bool) {
126-
127126
super.viewWillAppear(animated)
128127
isGranularUpdatingEnabled = true
129128
restoreScrollPositionIfNeeded()
130129
configureNavigationBar()
130+
restoreLogoStateForCurrentScrollPosition(scrollView: collectionView)
131131
}
132132

133133
override func viewWillTransition(to size: CGSize, with coordinator: any UIViewControllerTransitionCoordinator) {

0 commit comments

Comments
 (0)