Skip to content

Commit 715487d

Browse files
Carybelullis
authored andcommitted
Adds validation for values, aliases, descriptions, etc.
1 parent 4286826 commit 715487d

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/core/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ def type(self):
551551
@property
552552
def value_dict(self):
553553
if not hasattr(self, "_value_dict"):
554-
self._value_dict = self.json.get("value", {})
554+
self._value_dict = self.json.get("value") or {}
555555
return self._value_dict
556556

557557
@property

src/core/parsers/v1.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ def parse_statement(self, elements, first_command):
146146

147147
vvalue = self.parse_value(elements[2])
148148

149+
if vvalue is None:
150+
raise ParserException(f"Invalid value {elements[2]}")
151+
149152
if llen >= 3 and elements[1][0] == "A":
150153
aliases = []
151154
lang = elements[1][1:]
@@ -216,6 +219,9 @@ def parse_statement(self, elements, first_command):
216219
key = elements[index].strip()
217220
value = self.parse_value(elements[index + 1].strip())
218221

222+
if value is None:
223+
raise ParserException(f"Invalid value {elements[index + 1].strip()}")
224+
219225
if key[0] == "P": # PROPERTIES
220226
if not self.is_valid_property_id(key):
221227
raise ParserException(f"Invalid qualifier property {key}")

0 commit comments

Comments
 (0)