Remove unused Vite file system watcher (remix-run#13133)

Author: markdalgleish

.changeset/ninety-otters-repeat.md

@@ -0,0 +1,5 @@
+---
+"@react-router/dev": patch
+---
+
+Remove unused Vite file system watcher

packages/react-router-dev/config/config.ts

@@ -22,7 +22,6 @@ import {
   configRoutesToRouteManifest,
 } from "./routes";
 import { detectPackageManager } from "../cli/detectPackageManager";
-import { isReactRouterRepo } from "./is-react-router-repo";
 
 const excludedConfigPresetKeys = ["presets"] as const satisfies ReadonlyArray<
   keyof ReactRouterConfig
@@ -546,10 +545,6 @@ export async function createConfigLoader({
   let viteNodeContext = await ViteNode.createContext({
     root,
     mode: watch ? "development" : "production",
-    server: !watch ? { watch: null } : {},
-    ssr: {
-      external: ssrExternals,
-    },
   });
 
   let reactRouterConfigFile = findEntry(root, "react-router.config", {
@@ -732,22 +727,6 @@ export async function resolveEntryFiles({
   return { entryClientFilePath, entryServerFilePath };
 }
 
-export const ssrExternals = isReactRouterRepo()
-  ? [
-      // This is only needed within this repo because these packages
-      // are linked to a directory outside of node_modules so Vite
-      // treats them as internal code by default.
-      "react-router",
-      "react-router-dom",
-      "@react-router/architect",
-      "@react-router/cloudflare",
-      "@react-router/dev",
-      "@react-router/express",
-      "@react-router/node",
-      "@react-router/serve",
-    ]
-  : undefined;
-
 const entryExts = [".js", ".jsx", ".ts", ".tsx"];
 
 function findEntry(

packages/react-router-dev/vite/plugin.ts

@@ -41,6 +41,7 @@ import * as VirtualModule from "./virtual-module";
 import { resolveFileUrl } from "./resolve-file-url";
 import { combineURLs } from "./combine-urls";
 import { removeExports } from "./remove-exports";
+import { ssrExternals } from "./ssr-externals";
 import {
   type RouteChunkName,
   type RouteChunkExportName,
@@ -59,7 +60,6 @@ import {
   type ConfigLoader,
   createConfigLoader,
   resolveEntryFiles,
-  ssrExternals,
   configRouteToBranchRoute,
 } from "../config/config";
 import * as WithProps from "./with-props";

packages/react-router-dev/vite/ssr-externals.ts

@@ -0,0 +1,17 @@
+import { isReactRouterRepo } from "../config/is-react-router-repo";
+
+export const ssrExternals = isReactRouterRepo()
+  ? [
+      // This is only needed within this repo because these packages
+      // are linked to a directory outside of node_modules so Vite
+      // treats them as internal code by default.
+      "react-router",
+      "react-router-dom",
+      "@react-router/architect",
+      "@react-router/cloudflare",
+      "@react-router/dev",
+      "@react-router/express",
+      "@react-router/node",
+      "@react-router/serve",
+    ]
+  : undefined;

packages/react-router-dev/vite/vite-node.ts

@@ -4,36 +4,42 @@ import { installSourcemapsSupport } from "vite-node/source-map";
 import type * as Vite from "vite";
 
 import { preloadVite, getVite } from "./vite";
+import { ssrExternals } from "./ssr-externals";
 
 export type Context = {
   devServer: Vite.ViteDevServer;
   server: ViteNodeServer;
   runner: ViteNodeRunner;
 };
 
-export async function createContext(
-  viteConfig: Vite.InlineConfig = {}
-): Promise<Context> {
+export async function createContext({
+  root,
+  mode,
+}: {
+  root: Vite.UserConfig["root"];
+  mode: Vite.ConfigEnv["mode"];
+}): Promise<Context> {
   await preloadVite();
   const vite = getVite();
 
-  const devServer = await vite.createServer(
-    vite.mergeConfig(
-      {
-        server: {
-          preTransformRequests: false,
-          hmr: false,
-        },
-        optimizeDeps: {
-          noDiscovery: true,
-        },
-        configFile: false,
-        envFile: false,
-        plugins: [],
-      },
-      viteConfig
-    )
-  );
+  const devServer = await vite.createServer({
+    root,
+    mode,
+    server: {
+      preTransformRequests: false,
+      hmr: false,
+      watch: null,
+    },
+    ssr: {
+      external: ssrExternals,
+    },
+    optimizeDeps: {
+      noDiscovery: true,
+    },
+    configFile: false,
+    envFile: false,
+    plugins: [],
+  });
   await devServer.pluginContainer.buildStart({});
 
   const server = new ViteNodeServer(devServer);