Skip to content

Commit 847be0a

Browse files
SergeyKleymankibanamachine
authored andcommitted
[APM] Make 'sampling_rate' agent central config options available to … (elastic#241908)
Ref: PR elastic/elastic-otel-php#296 implements handling of `sampling_rate` central config option on the EDOT PHP side ## Summary This makes one more central-config setting available to EDOT PHP SDK/agents. An earlier equivalent PR was: elastic#241048 --------- Co-authored-by: kibanamachine <[email protected]>
1 parent 1d09540 commit 847be0a

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

x-pack/solutions/observability/plugins/apm/common/agent_configuration/setting_definitions/edot_sdk_settings.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ export const edotSDKSettings: RawSettingDefinition[] = [
118118
includeAgents: [
119119
'opentelemetry/java/elastic',
120120
'opentelemetry/nodejs/elastic',
121+
'opentelemetry/php/elastic',
121122
'opentelemetry/python/elastic',
122123
],
123124
},

x-pack/solutions/observability/plugins/apm/common/agent_configuration/setting_definitions/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ describe('filterByAgent', () => {
228228

229229
it('opentelemetry/php/elastic', () => {
230230
expect(getSettingKeysForAgent('opentelemetry/php/elastic')).toEqual(
231-
expect.arrayContaining(['logging_level', 'infer_spans'])
231+
expect.arrayContaining(['infer_spans', 'logging_level', 'sampling_rate'])
232232
);
233233
});
234234

0 commit comments

Comments
 (0)