Merged
Conversation
f9ff4fc to
4d22c4e
Compare
Contributor
Author
|
Original change is ok, but it seems that the upstream CI is broken for a long time, let me investigate this as a part of this PR .... |
4d22c4e to
2216efc
Compare
bf12b45 to
0a4d38d
Compare
tadamski
requested changes
Oct 20, 2025
multinode/pom-wildfly-client/pom.xml
Outdated
| <groupId>org.wildfly.launcher</groupId> | ||
| <artifactId>wildfly-launcher</artifactId> | ||
| <version>${version.wf.core}</version> | ||
| <version>1.0.2.Final</version> |
Contributor
There was a problem hiding this comment.
hmm maybe we can move it to version properties as well just to keep it consistent?
0a4d38d to
bb33d6c
Compare
tadamski
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wildfly is not using 2.0 branch any more, so we should use latest branch again.
https://github.com/wildfly/wildfly/blob/main/pom.xml#L539
See also related discussions here: https://issues.redhat.com/browse/JBEAP-29502#
See this link for launcher changes: https://issues.redhat.com/browse/WFCORE-7044