Skip to content

The BootableJarSupport should not include the module-info.class from JBoss Modules or potentially other dependencies being packaged #184

@jamezp

Description

@jamezp

The BootableJarSupport.packageBootableJar() packages up a bootable JAR. As part of this, it extracts JBoss Modules and the org.wildfly.core:wildfly-jar-boot dependencies into the created the JAR. However, this also includes the module-info.class from the jboss-module.jar which is invalid. We need to filter out the module-info.class files from getting added.

I don't think we want to create a module-info.class for the bootable JAR in general.

This is a snippet of what the JAR includes.

META-INF/MANIFEST.MF
provisioning.xml
wildfly.zip
module-info.class
LICENSE.txt
XPP3-LICENSE.txt
org/
org/jboss/
org/jboss/modules/
...
org/wildfly/
org/wildfly/core/
org/wildfly/core/jar/
org/wildfly/core/jar/boot/
...
schema/
schema/module-1_3.xsd
schema/module-1_2.xsd
schema/module-1_9.xsd
schema/module-1_7.xsd
schema/module-1_0.xsd
schema/module-1_5.xsd
schema/module-1_8.xsd
schema/module-1_6.xsd
schema/module-1_1.xsd
META-INF/
META-INF/INDEX.LIST
META-INF/maven/
META-INF/maven/org.jboss.modules/
META-INF/maven/org.jboss.modules/jboss-modules/
META-INF/maven/org.jboss.modules/jboss-modules/pom.properties
META-INF/maven/org.jboss.modules/jboss-modules/pom.xml
META-INF/maven/org.wildfly.core/
META-INF/maven/org.wildfly.core/wildfly-jar-boot/
META-INF/maven/org.wildfly.core/wildfly-jar-boot/pom.properties
META-INF/maven/org.wildfly.core/wildfly-jar-boot/pom.xml
META-INF/services/
META-INF/services/java.lang.System$LoggerFinder

The license is is for JBoss Modules too, currently ASLv2, which might be okay. We may want to consider filtering out the META-INF/maven/* and the META-INF/INDEX.LIST as well. The MANIFEST.MF looks okay.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions