adding range checks in get_tuple_from_simplex_local_id

Author: mtao

src/wmtk/autogen/tet_mesh/get_tuple_from_simplex_local_id.hpp

@@ -7,29 +7,11 @@
 #endif
 
 namespace wmtk::autogen::tet_mesh {
-/*
-namespace {
-template <size_t Dim>
-inline Tuple get_tuple_from_simplex_local_id_T(int8_t local_id, int64_t global_id)
-{
-const auto& arr = autogen::tet_mesh::auto_3d_table_complete_edge[local_id];
-assert(arr[Dim] == local_id);
-const auto& [lvid, leid, lfid] = arr;
-
-
-if (lvid < 0 || leid < 0 || lfid < 0) {
-    throw std::runtime_error("tuple_from_id failed");
-}
-Tuple tuple = Tuple(lvid, leid, lfid, global_id);
-// accessor as parameter
-assert(is_ccw(tuple)); // is_ccw also checks for validity
-return tuple;
-}
-} // namespace
-*/
 
 inline Tuple get_tuple_from_simplex_local_vertex_id(int8_t local_id, int64_t global_id)
 {
+    assert(local_id >= 0);
+    assert(local_id < 4);
     const auto& arr = autogen::tet_mesh::auto_3d_table_complete_vertex[local_id];
     const auto& [lvid, leid, lfid] = arr;
     assert(lvid == local_id);
@@ -45,6 +27,8 @@ inline Tuple get_tuple_from_simplex_local_vertex_id(int8_t local_id, int64_t glo
 }
 inline Tuple get_tuple_from_simplex_local_edge_id(int8_t local_id, int64_t global_id)
 {
+    assert(local_id >= 0);
+    assert(local_id < 6);
     const auto& arr = autogen::tet_mesh::auto_3d_table_complete_edge[local_id];
     const auto& [lvid, leid, lfid] = arr;
     assert(leid == local_id);
@@ -60,6 +44,8 @@ inline Tuple get_tuple_from_simplex_local_edge_id(int8_t local_id, int64_t globa
 }
 inline Tuple get_tuple_from_simplex_local_face_id(int8_t local_id, int64_t global_id)
 {
+    assert(local_id >= 0);
+    assert(local_id < 4);
     const auto& arr = autogen::tet_mesh::auto_3d_table_complete_face[local_id];
     const auto& [lvid, leid, lfid] = arr;
     assert(lfid == local_id);
@@ -73,8 +59,7 @@ inline Tuple get_tuple_from_simplex_local_face_id(int8_t local_id, int64_t globa
     assert(is_ccw(tuple)); // is_ccw also checks for validity
     return tuple;
 }
-inline Tuple
-get_tuple_from_simplex_local_id(PrimitiveType pt, int8_t local_id, int64_t global_fid)
+inline Tuple get_tuple_from_simplex_local_id(PrimitiveType pt, int8_t local_id, int64_t global_fid)
 {
     switch (pt) {
     case PrimitiveType::Vertex: return get_tuple_from_simplex_local_vertex_id(local_id, global_fid);

src/wmtk/autogen/tri_mesh/get_tuple_from_simplex_local_id.hpp

@@ -9,6 +9,9 @@
 namespace wmtk::autogen::tri_mesh {
     inline Tuple get_tuple_from_simplex_local_vertex_id(int8_t local_id, int64_t global_fid) {
 
+    assert(local_id >= 0);
+    assert(local_id < 3);
+
             assert(autogen::tri_mesh::auto_2d_table_complete_vertex[local_id][0] == local_id);
             const int64_t leid = autogen::tri_mesh::auto_2d_table_complete_vertex[local_id][1];
             Tuple v_tuple = Tuple(local_id, leid, -1, global_fid);
@@ -17,6 +20,8 @@ namespace wmtk::autogen::tri_mesh {
             return v_tuple;
     }
     inline Tuple get_tuple_from_simplex_local_edge_id(int8_t local_id, int64_t global_fid) {
+    assert(local_id >= 0);
+    assert(local_id < 3);
             assert(autogen::tri_mesh::auto_2d_table_complete_edge[local_id][1] == local_id);
             const int64_t lvid = autogen::tri_mesh::auto_2d_table_complete_edge[local_id][0];