Urgent inactive connection timeout removal

The recent commit removing the slow "connected but non-visible host item checking" broke inactive timeout disconnect functionality, causing every connection to time out even if it was still responsive.  libVNCClient has a `readTimeout` value but it doesn't appear to do anything (useful).

All inactive host detection is disabled for now, so unless something drastic happens, inactive hosts will just stay connected, no matter what the 'Auto-disconnect if inactive' is set to.  I will have to find some other way to detect inactivity later.

Author: willbprog127

src/app.cxx

@@ -794,29 +794,35 @@ void svConnectionWatcher (void *)
     }
   }
 
-  // do an inactive connection check
-  nSize = app->hostList->size();
-
-  // iterate through hostlist items
-  for (uint16_t i = 0; i <= nSize; i ++)
-  {
-    itm = static_cast<HostItem *>(app->hostList->data(i));
-
-    if (itm == NULL)
-      continue;
-
-    vnc = itm->vnc;
-
-    if (vnc == NULL || itm->isConnected == false)
-      continue;
-
-    // check if connection has been inactive, unless this itm is ignoring
-    if (vnc->inactiveSeconds >= app->nDeadTimeout && itm->ignoreInactive == false)
-      // remote host hasn't responded in time allotted, disconnect
-      VncObject::endAndDeleteViewer(&vnc);
-    else
-      vnc->inactiveSeconds ++;
-  }
+  // #### the code below is commented out until further notice.     ####
+  // #### with removal of checking connected but non-visible        ####
+  // #### hosts, the ability to check for unresponsive              ####
+  // #### hosts is now disabled until some other method is found.   ####
+  // #### will leave 'plumbing' in place in case I find a way later ####
+
+  //// do an inactive connection check
+  //nSize = app->hostList->size();
+
+  //// iterate through hostlist items
+  //for (uint16_t i = 0; i <= nSize; i ++)
+  //{
+    //itm = static_cast<HostItem *>(app->hostList->data(i));
+
+    //if (itm == NULL)
+      //continue;
+
+    //vnc = itm->vnc;
+
+    //if (vnc == NULL || itm->isConnected == false)
+      //continue;
+
+    //// check if connection has been inactive, unless this itm is ignoring
+    //if (vnc->inactiveSeconds >= app->nDeadTimeout && itm->ignoreInactive == false)
+      //// remote host hasn't responded in time allotted, disconnect
+      //VncObject::endAndDeleteViewer(&vnc);
+    //else
+      //vnc->inactiveSeconds ++;
+  //}
 
   // set timer to call this function again in 1 second
   // (do NOT change this interval as connection timeout

src/consts_enums.h

@@ -36,7 +36,7 @@
 #define CONSTS_H
 
 /* constants */
-#define SV_APP_VERSION  "0.5.1"  //"0.4.16"
+#define SV_APP_VERSION  "0.5.2"  //"0.4.16"
 
 #define SV_CURRENT_YEAR "2023"
 

src/vnc.cxx

@@ -133,6 +133,12 @@ void VncObject::createVNCObject (HostItem * itm)
       vnc->vncClient->GotCursorShape = VncObject::handleCursorShapeChange;
     }
 
+    // inactive timeout  !!!! #### readTimeout doesn't seem to work (sigh) ####
+    if (itm->ignoreInactive == true)
+      vnc->vncClient->readTimeout = 0;
+    else
+      vnc->vncClient->readTimeout = app->nDeadTimeout;
+
     // set up vnc compression and quality levels
     vnc->vncClient->appData.compressLevel = itm->compressLevel;
     vnc->vncClient->appData.qualityLevel = itm->qualityLevel;
@@ -445,14 +451,20 @@ void VncObject::handleCursorShapeChange (rfbClient * cl, int xHot, int yHot, int
 
 
 /* (static method) */
-void VncObject::handleFrameBufferUpdate (rfbClient * cl) //, int x, int y, int w, int h)
+void VncObject::handleFrameBufferUpdate (rfbClient * cl)
 {
+  if (cl == NULL)
+    return;
+
   VncObject * vnc = static_cast<VncObject *>(rfbClientGetClientData(cl, app->libVncVncPointer));
 
-  if (vnc == NULL || vnc->allowDrawing == false)
+  if (vnc == NULL)
     return;
 
-  app->vncViewer->redraw();
+  //vnc->inactiveSeconds = 0;
+
+  if (vnc->allowDrawing == true)
+    app->vncViewer->redraw();
 }
 
 
@@ -894,7 +906,7 @@ void VncObject::checkVNCMessages (VncObject * vnc)
   if (nMsg)
   {
     // reset inactive seconds so we don't automatically disconnect
-    vnc->inactiveSeconds = 0;
+    //vnc->inactiveSeconds = 0;
 
     if (HandleRFBServerMessage(vnc->vncClient) == FALSE)
     {

src/vnc.h

@@ -59,7 +59,7 @@ class VncObject
     imgCursor(NULL),
     nCursorXHot(0),
     nCursorYHot(0),
-    inactiveSeconds(0),
+    //inactiveSeconds(0),
     nLastScrollX(0),
     nLastScrollY(0),
     centeredX(0),
@@ -92,7 +92,7 @@ class VncObject
   Fl_RGB_Image * imgCursor;
   int nCursorXHot;
   int nCursorYHot;
-  uint16_t inactiveSeconds;
+  //uint16_t inactiveSeconds;
   int nLastScrollX;
   int nLastScrollY;
   int centeredX;