Skip to content

Commit 3fea7f4

Browse files
committed
re-enable multi-platform master images
This was inadvertently disabled by distributing the jobs on native runners. Configuring it for a single image is non-trivial: https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners And for a matrix of images more difficult still, without duplicating the workflow. Revert to QEMU and using --platforms to get multi-platform. This could likely be speeded up by using cross-compilation in the Dockerfiles if necessary.
1 parent fd0af0c commit 3fea7f4

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

.github/workflows/master.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
name: nightly-master
22

3-
concurrency:
4-
group: ${{ github.workflow }}-${{ github.ref }}
5-
cancel-in-progress: true
6-
73
on:
84
schedule:
95
- cron: "0 0 * * *"
@@ -12,25 +8,26 @@ on:
128
- 'master/Dockerfile'
139
- 'master/alpine/Dockerfile'
1410

11+
env:
12+
PLATFORMS: linux/amd64,linux/arm64
13+
1514
jobs:
1615
build:
16+
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
19-
platform:
20-
- docker: linux/amd64
21-
runner: ubuntu-24.04
22-
- docker: linux/arm64
23-
runner: ubuntu-24.04-arm
2419
variant:
2520
- type: ""
2621
suffix: ""
2722
- type: "-alpine"
2823
suffix: "/alpine"
29-
runs-on: ${{ matrix.platform.runner }}
3024
steps:
3125
- name: Checkout
3226
uses: actions/checkout@v4
3327

28+
- name: Set up QEMU
29+
uses: docker/setup-qemu-action@v3
30+
3431
- name: Set up Docker Buildx
3532
uses: docker/setup-buildx-action@v3
3633
with:
@@ -51,7 +48,7 @@ jobs:
5148
uses: docker/build-push-action@v6
5249
with:
5350
context: master${{ matrix.variant.suffix }}
54-
platforms: ${{ matrix.platform.docker }}
51+
platforms: ${{ env.PLATFORMS }}
5552
push: ${{ github.event_name == 'schedule' }}
5653
tags: bitcoin/bitcoin:master${{ matrix.variant.type }}
5754
cache-from: type=gha

0 commit comments

Comments
 (0)