test: check flipped channel policies when comparing against mainnet

Author: pinheadmz

src/warnet/lnchannel.py

@@ -47,7 +47,7 @@ def __init__(
         self.node2_fee_rate_milli_msat = node2_fee_rate_milli_msat
         self.node1_time_lock_delta = node1_time_lock_delta
         self.node2_time_lock_delta = node2_time_lock_delta
-        self.logger = logging.getLogger("lnchannel")
+        self.logger = logging.getLogger("lnchan")
 
     def __str__(self) -> str:
         return (
@@ -67,6 +67,28 @@ def __str__(self) -> str:
             f"time_lock_delta={self.node2_time_lock_delta}))"
         )
 
+    # Only used to compare warnet channels imported from a mainnet source file
+    # because pubkeys are unpredictable and node 1/2 might be swapped
+    def flip(self) -> "LNChannel":
+        return LNChannel(
+            # Keep the old pubkeys so the constructor doesn't just flip it back
+            node1_pub=self.node1_pub,
+            node2_pub=self.node2_pub,
+            capacity_msat=self.capacity_msat,
+            short_chan_id=self.short_chan_id,
+            # Flip the policies
+            node1_min_htlc=self.node2_min_htlc,
+            node2_min_htlc=self.node1_min_htlc,
+            node1_max_htlc=self.node2_max_htlc,
+            node2_max_htlc=self.node1_max_htlc,
+            node1_base_fee_msat=self.node2_base_fee_msat,
+            node2_base_fee_msat=self.node1_base_fee_msat,
+            node1_fee_rate_milli_msat=self.node2_fee_rate_milli_msat,
+            node2_fee_rate_milli_msat=self.node1_fee_rate_milli_msat,
+            node1_time_lock_delta=self.node2_time_lock_delta,
+            node2_time_lock_delta=self.node1_time_lock_delta,
+        )
+
     def policy_match(self, ch2: "LNChannel") -> bool:
         assert isinstance(ch2, LNChannel)
 

test/graph_test.py

@@ -98,11 +98,15 @@ def verify_ln_channel_policies(self):
                 expected_chan = LNDNode.lnchannel_from_json(expected[chan_index])
                 actual_chan = LNDNode.lnchannel_from_json(actual_chan_json)
                 if not expected_chan.channel_match(actual_chan):
-                    raise Exception(
-                        f"Channel policy doesn't match source: {actual_chan.short_chan_id}\n"
-                        + f"Actual:\n{actual_chan}\n"
-                        + f"Expected:\n{expected_chan}\n"
+                    self.log.info(
+                        f"Channel {chan_index} policy mismatch, testing flipped channel: {actual_chan.short_chan_id}"
                     )
+                    if not expected_chan.channel_match(actual_chan.flip()):
+                        raise Exception(
+                            f"Channel policy doesn't match source: {actual_chan.short_chan_id}\n"
+                            + f"Actual:\n{actual_chan}\n"
+                            + f"Expected:\n{expected_chan}\n"
+                        )
 
 
 if __name__ == "__main__":